Restore Managed Navigation Path Configuration - #9
Merged
Conversation
Contributor
📝 WalkthroughWalkthroughThe PR removes informational logging and signpost instrumentation across FHIR interpretation, chat, study, HealthKit, Firebase, QR-code, configuration, and application lifecycle flows. Functional behavior, cancellation, validation, persistence, and error handling remain. The Spezi package revision is updated in both package references. The Firebase end-to-end test plan becomes the default plan. The archive lane restores and verifies the required Spezi Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
PSchmiedmayer
force-pushed
the
fix-onboarding-navigation
branch
from
August 8, 2026 05:51
af01fcc to
ab3d1c8
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Plainly/SharedContext/AppDiagnostics.swift`:
- Around line 37-53: Update AppDiagnostics.logPublicPayload in
Plainly/SharedContext/AppDiagnostics.swift (lines 37-53) to add a release-safe
opt-in gate before emitting raw payload content; when disabled, log only
metadata such as counts, correlation IDs, and private payload hashes. Apply the
resulting safe behavior to callers in
Plainly/FHIRInterpretation/UserStudy/OpenAIRequestInterceptor.swift (lines
155-159, 283, and 331-337) and
Plainly/FHIRInterpretation/UserStudy/UserStudyChatViewModel.swift (lines 535,
572, 634-638, 662-668, and 677-681); no direct caller changes are required if
they are corrected through logPublicPayload.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 314f5a2c-c15a-4e25-acf6-3f0d5f814bba
⛔ Files ignored due to path filters (1)
Plainly.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolvedis excluded by!**/Package.resolved
📒 Files selected for processing (5)
Plainly.xcodeproj/project.pbxprojPlainly/FHIRInterpretation/UserStudy/OpenAIRequestInterceptor.swiftPlainly/FHIRInterpretation/UserStudy/UserStudyChatViewModel.swiftPlainly/SharedContext/AppDiagnostics.swiftPlainlyShared/Package.swift
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/deployment.yml:
- Around line 125-135: The iosapptestflightdeployment job is not gated by the
build-and-test validation workflow. Restore the buildandtest reusable workflow
and include it in iosapptestflightdeployment’s needs, or add an equivalent
explicit required-check dependency while preserving determineenvironment and
vars.
In `@Plainly.xcodeproj/xcshareddata/xcschemes/Plainly.xcscheme`:
- Around line 35-37: Update the TestPlanReference in the Plainly scheme so
“Plainly Firebase End-to-End.xctestplan” is the scheme’s explicit default
instead of “Plainly.xctestplan,” ensuring test runs without -testPlan select the
Firebase plan and its PLAINLY_RUN_FIREBASE_E2E=1 setting.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: c8e6447c-0d3b-43cd-83fa-f8850e91146f
⛔ Files ignored due to path filters (1)
Plainly.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolvedis excluded by!**/Package.resolved
📒 Files selected for processing (5)
.github/workflows/deployment.ymlPlainly.xcodeproj/project.pbxprojPlainly.xcodeproj/xcshareddata/xcschemes/Plainly.xcschemePlainlyShared/Package.swiftfastlane/Fastfile
🚧 Files skipped from review as they are similar to previous changes (1)
- PlainlyShared/Package.swift
Contributor
There was a problem hiding this comment.
♻️ Duplicate comments (1)
Plainly.xcodeproj/xcshareddata/xcschemes/Plainly.xcscheme (1)
36-37: 🎯 Functional Correctness | 🟠 MajorMake the Firebase test plan the explicit scheme default.
The change removes
default = "NO"fromPlainly Firebase End-to-End.xctestplan, but Line [33] still marksPlainly.xctestplanasdefault = "YES". Runs without an explicit-testPlanwill therefore continue to select the plain test plan. Setdefault = "YES"on the Firebase reference and remove it from the plain reference.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@Plainly.xcodeproj/xcshareddata/xcschemes/Plainly.xcscheme` around lines 36 - 37, Update the TestPlanReference entries in the Plainly scheme so Plainly Firebase End-to-End.xctestplan has default = "YES", while Plainly.xctestplan no longer has the default flag. Keep the existing test plan references unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Duplicate comments:
In `@Plainly.xcodeproj/xcshareddata/xcschemes/Plainly.xcscheme`:
- Around line 36-37: Update the TestPlanReference entries in the Plainly scheme
so Plainly Firebase End-to-End.xctestplan has default = "YES", while
Plainly.xctestplan no longer has the default flag. Keep the existing test plan
references unchanged.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: d398a926-8842-4588-9ff1-b4187f033dec
⛔ Files ignored due to path filters (1)
Plainly.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolvedis excluded by!**/Package.resolved
📒 Files selected for processing (23)
Plainly.xcodeproj/project.pbxprojPlainly.xcodeproj/xcshareddata/xcschemes/Plainly.xcschemePlainly/FHIRInterpretation/FHIRInterpretationModule.swiftPlainly/FHIRInterpretation/UserStudy/IntakeQuestionnaireSheet.swiftPlainly/FHIRInterpretation/UserStudy/OpenAIRequestInterceptor.swiftPlainly/FHIRInterpretation/UserStudy/QuestionnaireLoader.swiftPlainly/FHIRInterpretation/UserStudy/StudyHomeView.swiftPlainly/FHIRInterpretation/UserStudy/SurveySheet.swiftPlainly/FHIRInterpretation/UserStudy/UserStudyChatView.swiftPlainly/FHIRInterpretation/UserStudy/UserStudyChatViewModel.swiftPlainly/Modules/FirebaseUpload.swiftPlainly/Onboarding/HealthKitPermissions.swiftPlainly/PlainlyDelegate.swiftPlainly/PlainlyStandard.swiftPlainly/RootView.swiftPlainly/SharedContext/AppDiagnostics.swiftPlainly/Study Flow (QR Code)/ScanQRCodeSheet.swiftPlainly/Study Flow (QR Code)/StudyQRCodeButtons.swiftPlainlyShared/Package.swiftPlainlyShared/Sources/PlainlyShared/AppConfigFile.swiftPlainlyShared/Sources/PlainlyShared/Chat/Multiple Resources/FHIRGetResourceLLMFunction.swiftPlainlyShared/Sources/PlainlyShared/Chat/Multiple Resources/FHIRMultipleResourceInterpreter.swiftfastlane/Fastfile
💤 Files with no reviewable changes (15)
- Plainly/FHIRInterpretation/UserStudy/QuestionnaireLoader.swift
- PlainlyShared/Sources/PlainlyShared/AppConfigFile.swift
- Plainly/Study Flow (QR Code)/StudyQRCodeButtons.swift
- Plainly/Modules/FirebaseUpload.swift
- Plainly/Study Flow (QR Code)/ScanQRCodeSheet.swift
- PlainlyShared/Sources/PlainlyShared/Chat/Multiple Resources/FHIRGetResourceLLMFunction.swift
- Plainly/SharedContext/AppDiagnostics.swift
- Plainly/RootView.swift
- Plainly/FHIRInterpretation/UserStudy/IntakeQuestionnaireSheet.swift
- Plainly/PlainlyDelegate.swift
- Plainly/PlainlyStandard.swift
- Plainly/FHIRInterpretation/UserStudy/SurveySheet.swift
- Plainly/FHIRInterpretation/FHIRInterpretationModule.swift
- Plainly/FHIRInterpretation/UserStudy/UserStudyChatViewModel.swift
- Plainly/Onboarding/HealthKitPermissions.swift
🚧 Files skipped from review as they are similar to previous changes (2)
- PlainlyShared/Package.swift
- fastlane/Fastfile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restore Managed Navigation Path Configuration
♻️ Current situation & Problem
The managed-navigation state fix moved initial path configuration directly into the initializer, despite the existing Spezi workaround that keeps the direct configuration call in a helper to avoid repeated view updates with an external path. CI archives also need to preserve the Textual Swift package trait until XcodeProj #1049 adds native support.
⚙️ Release Notes
✅ Testing
git diff --checkCode of Conduct & Contributing Guidelines
By creating and submitting this pull request, you agree to follow our
Code of Conduct
and Contributing Guidelines: