Skip to content

Conversation

@mxochicale
Copy link
Contributor

@mxochicale mxochicale commented Jul 5, 2024

Hi @thompson318 @MattClarkson

There might other bits to update but I think I fixed #37 by updating pyside2 to pyside6 and adding missing vtk steps self.vtk_overlay_window.Initialize() and self.vtk_overlay_window.Start(). Would you please review it!

Some other pending bits might be:

  • How to kill apps form the terminal ? "ps -ef | grep "test_sksurgery" | awk '{print $2}' | xargs kill" ?
  • Steps for quick tests in the main readme.
  • Pass ci?

Thanks,
Miguel

@mxochicale mxochicale requested a review from thompson318 July 5, 2024 14:44
Copy link
Collaborator

@thompson318 thompson318 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mxochicale for looking into this. I think that should solve the problems that @younes1010 identified. At the moment the github actions are failing. I'd like to try and sort that before approving/merging.

Copy link
Collaborator

@thompson318 thompson318 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @mxochicale. I've made some changes to get tests passing. Minor change to conda notes: we shouldn't need to install the development requirements to run the tutorial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

QWidget: Must construct a QApplication before a QWidget

3 participants