-
-
Notifications
You must be signed in to change notification settings - Fork 34
Mooncake rrules for integrals - 1 #286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| IntegralsForwardDiffExt = "ForwardDiff" | ||
| IntegralsMCIntegrationExt = "MCIntegration" | ||
| IntegralsZygoteExt = ["Zygote", "ChainRulesCore"] | ||
| IntegralsMooncakeExt = ["Mooncake", "Zygote", "ChainRulesCore"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is zygote needed here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh the ZygoteVJP? Ehh I'd say just remove it, we need to phase out Zygote.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's merge first though, so it's in history.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay Ill add these changes in the next PR. Thanks !
Addresses part 4 of SciMLSensitivity issue #1279 SciML/SciMLSensitivity.jl#1279.
To Do:
I will open a subsequent seperate PR that additionally handles Batching Integral Function case AND nested AD + tests.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.