Skip to content

Conversation

@AstitvaAggarwal
Copy link
Member

@AstitvaAggarwal AstitvaAggarwal commented Dec 5, 2025

Addresses part 4 of SciMLSensitivity issue #1279 SciML/SciMLSensitivity.jl#1279.

  1. This PR adds Mooncake AD for sensitivity for the non Batching Integral Function case for all quadrature algs.
  2. Works with One Dimensional limits for the integrals, scalar or a vector of parameters in the IntegralProblem.
  3. Tests for all the above.

To Do:

  1. Add more comments and documentation for code changes?

I will open a subsequent seperate PR that additionally handles Batching Integral Function case AND nested AD + tests.

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

@AstitvaAggarwal AstitvaAggarwal marked this pull request as draft December 5, 2025 17:30
@AstitvaAggarwal AstitvaAggarwal marked this pull request as ready for review December 12, 2025 02:00
@AstitvaAggarwal AstitvaAggarwal changed the title Mooncake rrules for integrals Mooncake rrules for integrals - 1 Dec 12, 2025
@yebai
Copy link

yebai commented Dec 13, 2025

cc @ChrisRackauckas

@AstitvaAggarwal AstitvaAggarwal marked this pull request as draft December 14, 2025 22:33
@AstitvaAggarwal AstitvaAggarwal marked this pull request as ready for review December 14, 2025 22:33
IntegralsForwardDiffExt = "ForwardDiff"
IntegralsMCIntegrationExt = "MCIntegration"
IntegralsZygoteExt = ["Zygote", "ChainRulesCore"]
IntegralsMooncakeExt = ["Mooncake", "Zygote", "ChainRulesCore"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is zygote needed here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh the ZygoteVJP? Ehh I'd say just remove it, we need to phase out Zygote.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's merge first though, so it's in history.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay Ill add these changes in the next PR. Thanks !

@ChrisRackauckas ChrisRackauckas merged commit 214691e into SciML:master Dec 15, 2025
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants