Bugfix load policies as they were saved even with commas - #12
Merged
favipcj merged 2 commits intoFeb 23, 2026
Conversation
…s even if they have commands
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to cover possible scenarios in which a policy could contain a comma that is not a delimiter
If comma was set as delimiter, it's expected that the policy values were split by a comma. But to avoid this kind of scenarios apache/casbin-pycasbin#292 in which logic had to be added to escape or validated how the policy needs to be split, we can load the policies as they were saved into the database.
That is why this was submitted as a bugfix, as currently the following scenarios is happening:
values = ["name, surname", "another_value"]"name, surname, another_value"when requesting data forget_grouping_policyorget_roles_for_user, which was of course returning incorrect values