evol: turning color of switch buttons to red when they are off - #86
Merged
Conversation
Mael-RABOT
approved these changes
Sep 3, 2026
Arcod7
reviewed
Sep 3, 2026
Arcod7
left a comment
Arcod7
left a comment
Contributor
There was a problem hiding this comment.
I feel like that's a bit aggressive and not aligned well with the general theme, couldn't we try just not putting accent color when OFF ?
Contributor
An electric orange would be more inline with the overall theme, but could pose problems with colorblindness, red it intuitive and avoid such problem |
m-brl
approved these changes
Sep 7, 2026
Arcod7
approved these changes
Sep 7, 2026
Contributor
|
After having a look, it looks ok for me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OP#71
Changing the color of switch buttons to red when they are off
Before:
After:
Enregistrement.de.l.ecran.2026-09-03.a.17.39.29.mov
Same on 3D visualization options, before:
After: