fix(pixi): source dds_env.sh from activation, not only the launch wrappers - #71
Merged
Conversation
…ppers scripts/pixi_lucy_launch.sh sources scripts/dds_env.sh before launching, so the stack runs with ROS_AUTOMATIC_DISCOVERY_RANGE=LOCALHOST and a CycloneDDS config pinned to 127.0.0.1 with multicast off. Pixi activation did not, so a `pixi shell` or `pixi run` got Jazzy's default subnet discovery instead. Two consequences: - ros2 CLI commands from a dev shell could not discover a running stack. Same RMW on both sides, but incompatible discovery config, so the participants never found each other: `ros2 control list_controllers` hangs on "waiting for service /controller_manager/list_controllers" against a healthy stack. - Subnet discovery merges anyone else's Lucy on the network into the graph -- two robot_state_publishers and two controller_managers driving the same joints, which is precisely what dds_env.sh exists to prevent. Added to both activation blocks: target.linux overrides target.unix rather than merging with it. Sourcing the script twice is a no-op: _lucy_cyclone_uri returns early when CYCLONEDDS_URI is already set, and _lucy_dds_range re-exports the same values.
Mael-RABOT
approved these changes
Sep 8, 2026
charlesmadjeri
approved these changes
Sep 8, 2026
Arcod7
added a commit
that referenced
this pull request
Sep 9, 2026
* hotfix(config): change branch from 'dev' to 'master' for repos Signed-off-by: Charles Madjeri <80175305+charlesmadjeri@users.noreply.github.com> * fix(install): verbose install, quit keys on menu (#69) * fix(install): verbose install, quit keys on menu * fix: remove quit test * fix(pixi): source dds_env.sh from activation, not only the launch wrappers (#71) scripts/pixi_lucy_launch.sh sources scripts/dds_env.sh before launching, so the stack runs with ROS_AUTOMATIC_DISCOVERY_RANGE=LOCALHOST and a CycloneDDS config pinned to 127.0.0.1 with multicast off. Pixi activation did not, so a `pixi shell` or `pixi run` got Jazzy's default subnet discovery instead. Two consequences: - ros2 CLI commands from a dev shell could not discover a running stack. Same RMW on both sides, but incompatible discovery config, so the participants never found each other: `ros2 control list_controllers` hangs on "waiting for service /controller_manager/list_controllers" against a healthy stack. - Subnet discovery merges anyone else's Lucy on the network into the graph -- two robot_state_publishers and two controller_managers driving the same joints, which is precisely what dds_env.sh exists to prevent. Added to both activation blocks: target.linux overrides target.unix rather than merging with it. Sourcing the script twice is a no-op: _lucy_cyclone_uri returns early when CYCLONEDDS_URI is already set, and _lucy_dds_range re-exports the same values. * Migrating to v0.2.1 --------- Signed-off-by: Charles Madjeri <80175305+charlesmadjeri@users.noreply.github.com> Co-authored-by: Maël RABOT <mael.rabot@epitech.eu> Co-authored-by: Charles Madjeri <80175305+charlesmadjeri@users.noreply.github.com> Co-authored-by: Antoine ESMAN <antoine.esman@epitech.eu> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OP#227
Pixi activation didn't source
scripts/dds_env.shlike the launch wrappers do, soros2CLI commands from a dev shell used subnet discovery and couldn't see a stack running with localhost-only discovery.