Skip to content
This repository was archived by the owner on Mar 3, 2023. It is now read-only.

Conversation

@bitforcesrl
Copy link

Description

The math that is applied in the image component to create resize params for images served from cdn.shopify can generate float numbers. In this case the CDN is ignoring the params resulting in wrong generated images

img with float heght, that is not resized properly

the same image with integer height value, returned properly => img

Additional context

We've added a Math.ceil to solve the problem


@bitforcesrl
Copy link
Author

Hi @frehner i've signed the CLA for both bitforcesrl and tr-bitforce and reopened the PR but it still shows errors.
What should i do? thanks

@frehner
Copy link
Contributor

frehner commented Jan 3, 2023

Looks like the CLA is happy, so whatever you did worked.

You're missing a changelog, so do you mind adding one? You should be able to run yarn changeset add at the project root and it will walk you though it. This would be a patch change. (I'll update the CONTRIBUTING.md doc to have this info for the future).

Thanks!

@frehner
Copy link
Contributor

frehner commented Feb 23, 2023

Closing for now. There is a complete rework of the Image component that incorporates this PR I believe. #114

@frehner frehner closed this Feb 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants