Open
Conversation
* Allow reverse_conversion & conversion procs as value * Extract UnitConversion into Dynamic and Static classes * Test dynamic conversion from Unit class
793e768 to
f01b652
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to solve #59 by allowing dynamic unit system definitions.
Current unit system definitions assume units are all proportional to each other
y = a * x. This change allows any conversion but removes the ability to cache dynamic unit systems, which might be good enough for small ones.You can create dynamic systems by passing a
conversionand areverse_conversionproc and an optional conversion description. Please take a look at the Temperature example below. The PR also has temperature acceptance tests as proof of concept.Notes: