Add CPSC eFiling reference disclosures - #961
Open
ruba-ruba wants to merge 1 commit into
Open
Conversation
Introduce "reference" disclosures — leaves that wire up a metaobject definition rather than being displayed to buyers — and add the CPSC eFiling grouping and PGA reference-set leaf. Reference leaves still carry jurisdictions/legal_citation/source but omit display copy and display_preferences. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Adds support for reference disclosures to the
Disclosuremodel and introduces the two CPSC eFiling nodes that carry ametaobject_definition.Why
CPSC eFiling (PGA) data isn't buyer-facing display copy — it's a structured reference set backed by a metaobject definition. The existing
Disclosuremodel only modeled display-only leaves (title/content/display_preferences), so it couldn't represent this. Moving these nodes into the public taxonomy repo makes it the single source of truth for all disclosure data (no internal-only overlay).What
metaobject_definitionis a "reference" disclosure (reference?). It's exempt from display-only leaf rules (title/content/display_preferences) but still requiresjurisdictions+legal_citation+source. New validation ensuresmetaobject_definitionis well-formed (a hash definingdisplay_name_key, only on leaves).cpsc_efiling(grouping) +us-cpsc-efiling-pga_reference_set(reference leaf) todata/disclosures.yml, with jurisdictions[US], legal citation16 CFR 1110, source CPSC eFiling URL, and a fullmetaobject_definition(fields: certifier_id, product_id, version_id).Verification
test_unitandtest_integrationgreen (unit 433, integration 6, model 24).vet_schemaunaffected (disclosures aren't covered by cue schemas).