Added new fencing categories and changed attributes - #969
Open
cedricnavis wants to merge 3 commits into
Open
Conversation
Added 41 new categories Changed (Removed and added) attributes to categories, not only for the 41 added but also for already existing categories.
Author
|
Hi! I made changes to the fencing taxonomy, adding new categories and changing attributes to better fit fencing in general since I work for a fencing company using shopify. Could someone approve the workflow run to allow all the tests to run? Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added 41 new categories in Fencing
Changed (removed and added) attributes to categories, not only for the 41 added but also for already existing categories in Fencing to make it more accurate and complete parts that were started but not finished.
The Fencing foil blades category should have been moved into Fencing Foils but it created a list of problems, as translations were already implemented for the ID's higher up and didn't know any effective methods to do it.
View a breakdown of the 41 new categories (Green: Added, Red: Already existent)
Shopify Taxonomy.pdf
**Categories names are different in the PR, they where simplified in the mindmap to accelerate the process.
**No translations were made