Index RBS attribute methods - #970
Open
soutaro wants to merge 3 commits into
Open
Conversation
vinistock
reviewed
Jul 31, 2026
vinistock
left a comment
vinistock
left a comment
Member
There was a problem hiding this comment.
Just a few things, but it looks good. I can't believe we forgot attributes on RBS!
| Signatures::Simple(Box::new([])) | ||
| }; | ||
|
|
||
| let definition = Definition::Method(Box::new(MethodDefinition::new( |
Member
There was a problem hiding this comment.
We have specific definitions for AttrWriter, AttrReader and AttrAccessor. Also, attributes don't carry a name offset and regular offset, since there's no distinction.
Contributor
Author
There was a problem hiding this comment.
The Attr* definitions do not support singleton attribute syntax in RBS, such as attr_reader self.name: String. I can extend them if it's better, but I don't think it would be worthwhile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Index RBS
attr_reader,attr_writer, andattr_accessormembers.RBS attributes are represented as
MethodDefinitions because the existing attribute-definition variants cannot represent singleton attributes such asattr_reader self.foo: String.This includes instance and singleton attributes, visibility, comments, and
deprecatedannotations. Writers are indexed with one required positional parameter.