Skip to content

Commit c3d4e3f

Browse files
committed
fix for PR comments
1 parent df23cd0 commit c3d4e3f

File tree

6 files changed

+24
-8
lines changed

6 files changed

+24
-8
lines changed

packages/ui-extensions/src/surfaces/admin/components/patterns/emptyState.ab.doc.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,11 @@ const data: ReferenceEntityTemplateSchema = {
2626
code: 'examples/emptyState.html',
2727
language: 'preview',
2828
},
29+
{
30+
title: 'jsx',
31+
code: 'examples/emptyState.jsx',
32+
language: 'preview-jsx',
33+
},
2934
],
3035
},
3136
},

packages/ui-extensions/src/surfaces/admin/components/patterns/examples/index.jsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
<s-section accessibilityLabel="Empty state section">
1616
<s-grid gap="base" justifyItems="center" paddingBlock="large-400">
1717
<s-box maxInlineSize="200px" maxBlockSize="200px">
18+
{/* aspectRatio should match the actual image dimensions (width/height) */}
1819
<s-image
1920
aspectRatio="1/0.5"
2021
src="https://cdn.shopify.com/static/images/polaris/patterns/callout.png"

packages/ui-extensions/src/surfaces/admin/components/patterns/examples/resourceList.html

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
<s-grid gridTemplateColumns="1fr auto" gap="small-200" alignItems="center">
55
<s-text-field icon="search" placeholder="Filter customers"></s-text-field>
66
<s-button commandFor="tagged-with">Tagged with</s-button>
7-
<s-popover placement="bottom-start" id="tagged-with">
7+
<s-popover id="tagged-with">
88
<s-stack gap="small-200" padding="small-200">
99
<s-text-field value="VIP" placeholder="Add tag"></s-text-field>
1010
<s-link href="">Clear</s-link>
@@ -14,7 +14,7 @@
1414
<s-button variant="secondary">Save</s-button>
1515
</s-grid>
1616

17-
<s-stack paddingInline="base">
17+
<s-stack direction="inline" gap="small-400" paddingInline="base">
1818
<s-clickable-chip removable>Tagged with VIP</s-clickable-chip>
1919
</s-stack>
2020

@@ -27,7 +27,7 @@
2727
</s-grid>
2828

2929
<s-stack>
30-
<s-clickable borderstyle="solid none none none" border="base" paddingInline="base" paddingBlock="small">
30+
<s-clickable borderStyle="solid none none none" border="base" paddingInline="base" paddingBlock="small">
3131
<s-grid gridTemplateColumns="1fr auto" gap="base" alignItems="center">
3232
<s-stack direction="inline" gap="small" alignItems="center">
3333
<s-checkbox></s-checkbox>
@@ -40,7 +40,7 @@
4040
<s-button icon="menu-horizontal" variant="tertiary" accessibilityLabel="Actions for Mae Jemison"></s-button>
4141
</s-grid>
4242
</s-clickable>
43-
<s-clickable borderstyle="solid none none none" border="base" paddingInline="base" paddingBlock="small">
43+
<s-clickable borderStyle="solid none none none" border="base" paddingInline="base" paddingBlock="small">
4444
<s-grid gridTemplateColumns="1fr auto" gap="base" alignItems="center">
4545
<s-stack direction="inline" gap="small" alignItems="center">
4646
<s-checkbox></s-checkbox>

packages/ui-extensions/src/surfaces/admin/components/patterns/examples/resourceList.jsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
<s-grid gridTemplateColumns="1fr auto" gap="small-200" alignItems="center">
55
<s-text-field icon="search" placeholder="Filter customers"></s-text-field>
66
<s-button commandFor="tagged-with">Tagged with</s-button>
7-
<s-popover placement="bottom-start" id="tagged-with">
7+
<s-popover id="tagged-with">
88
<s-stack gap="small-200" padding="small-200">
99
<s-text-field value="VIP" placeholder="Add tag"></s-text-field>
1010
<s-link href="">Clear</s-link>
@@ -14,7 +14,7 @@
1414
<s-button variant="secondary">Save</s-button>
1515
</s-grid>
1616

17-
<s-stack paddingInline="base">
17+
<s-stack direction="inline" gap="small-400" paddingInline="base">
1818
<s-clickable-chip removable>Tagged with VIP</s-clickable-chip>
1919
</s-stack>
2020

@@ -27,7 +27,7 @@
2727
</s-grid>
2828

2929
<s-stack>
30-
<s-clickable borderstyle="solid none none none" border="base" paddingInline="base" paddingBlock="small">
30+
<s-clickable borderStyle="solid none none none" border="base" paddingInline="base" paddingBlock="small">
3131
<s-grid gridTemplateColumns="1fr auto" gap="base" alignItems="center">
3232
<s-stack direction="inline" gap="small" alignItems="center">
3333
<s-checkbox></s-checkbox>
@@ -40,7 +40,7 @@
4040
<s-button icon="menu-horizontal" variant="tertiary" accessibilityLabel="Actions for Mae Jemison"></s-button>
4141
</s-grid>
4242
</s-clickable>
43-
<s-clickable borderstyle="solid none none none" border="base" paddingInline="base" paddingBlock="small">
43+
<s-clickable borderStyle="solid none none none" border="base" paddingInline="base" paddingBlock="small">
4444
<s-grid gridTemplateColumns="1fr auto" gap="base" alignItems="center">
4545
<s-stack direction="inline" gap="small" alignItems="center">
4646
<s-checkbox></s-checkbox>

packages/ui-extensions/src/surfaces/admin/components/patterns/footerHelp.ab.doc.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,11 @@ const data: ReferenceEntityTemplateSchema = {
3131
code: 'examples/footerHelp.html',
3232
language: 'preview',
3333
},
34+
{
35+
title: 'jsx',
36+
code: 'examples/footerHelp.jsx',
37+
language: 'preview-jsx',
38+
},
3439
],
3540
},
3641
},

packages/ui-extensions/src/surfaces/admin/components/patterns/resourceList.ab.doc.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,11 @@ const data: ReferenceEntityTemplateSchema = {
3434
code: 'examples/resourceList.html',
3535
language: 'preview',
3636
},
37+
{
38+
title: 'jsx',
39+
code: 'examples/resourceList.jsx',
40+
language: 'preview-jsx',
41+
},
3742
],
3843
},
3944
},

0 commit comments

Comments
 (0)