Footer Help and Resource List Patterns #3523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
We detected some changes in |
jas7457
requested changes
Oct 28, 2025
Contributor
jas7457
left a comment
jas7457
left a comment
There was a problem hiding this comment.
Mainly looking good, just caught a few things. Nice!
packages/ui-extensions/src/surfaces/admin/components/patterns/footerHelp.ab.doc.ts
Show resolved
Hide resolved
packages/ui-extensions/src/surfaces/admin/components/patterns/resourceList.ab.doc.ts
Show resolved
Hide resolved
packages/ui-extensions/src/surfaces/admin/components/patterns/examples/resourceList.html
Outdated
Show resolved
Hide resolved
packages/ui-extensions/src/surfaces/admin/components/patterns/examples/resourceList.jsx
Outdated
Show resolved
Hide resolved
packages/ui-extensions/src/surfaces/admin/components/patterns/examples/resourceList.jsx
Outdated
Show resolved
Hide resolved
jas7457
approved these changes
Oct 29, 2025
Contributor
jas7457
left a comment
jas7457
left a comment
There was a problem hiding this comment.
Changes look good, nice job!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
We did not have a Footer Help or Resource List pattern. A few aria-labels should have used accessibilityLabel instead. There was a typo with SetupGuide. s-image on EmptyState and calloutCard resulted in odd LLM rendering due to aspect ratio.
Solution
Add patterns for Footer Help and Resource List. Change aria-labels for accessibilityLabel on button and clickable where applicable. Fix typo to Setup guide. Added comment to guide LLM to match image's aspect ratio to actual width and height.
🎩
Checklist