-
Notifications
You must be signed in to change notification settings - Fork 89
Combine videos query update #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Combine videos query update #67
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates project configurations, migrates UI components to use ViewBinding with edge-to-edge support, enhances media picking for Android 13/14, and specifically improves the combine-videos feature by detecting audio streams and normalizing FPS.
- Add JDK and Gradle updates for build environments.
- Migrate all activities from Kotlin synthetic imports to ViewBinding and introduce
enableEdgeToEdge. - Enhance
CombineVideosActivityto detect audio streams (hasAudio) and normalize frame rates.
Reviewed Changes
Copilot reviewed 78 out of 80 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| jitpack.yml | Added support for OpenJDK 8 alongside 11 |
| gradle/wrapper/gradle-wrapper.properties | Upgraded Gradle distribution to 8.5-bin |
| gradle.properties | Suppress compileSdk 35 warnings with new flag |
| app/src/main/res/values/themes.xml | Switched to NoActionBar theme and added toolbar style |
| app/src/main/res/values/strings.xml | Inserted time-picker strings block |
| app/src/main/res/layout/toolbar_app.xml | New toolbar layout without ActionBar |
| app/src/main/java/.../utils/ExtensionsUtils.kt | Added enableEdgeToEdge extension |
| app/src/main/java/com/simform/videoimageeditor/videoProcessActivity/CombineVideosActivity.kt | Improved video combining logic (audio detection, fps normalization) |
| app/src/main/res/layout/activity_change_audio_valume.xml | Included toolbar in audio layout (typo in filename) |
Comments suppressed due to low confidence (3)
app/src/main/res/layout/activity_change_audio_valume.xml:1
- The filename 'activity_change_audio_valume.xml' contains a typo ('valume'). Rename it to 'activity_change_audio_volume.xml' and update references.
<?xml version="1.0" encoding="utf-8"?>
app/src/main/res/values/strings.xml:119
- [nitpick] The resource name 'title' is too generic and may collide with other modules. Consider renaming to 'time_picker_title' or namespace it for clarity.
<string name="title">title</string>
app/src/main/res/values/strings.xml:114
- XML resource files do not support '//' comments; this line will break parsing. Replace with a proper XML comment: .
// Time Picker
app/src/main/java/com/simform/videoimageeditor/videoProcessActivity/CombineVideosActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/simform/videoimageeditor/videoProcessActivity/CombineVideosActivity.kt
Show resolved
Hide resolved
7c2cd2c to
2fe5e6f
Compare
2fe5e6f to
a7699b2
Compare
a7699b2 to
f1b3a5e
Compare
Update the query for combine videos