Skip to content

Conversation

@Rajan-p-simform
Copy link

Update the query for combine videos

  • Identify the audio streams
  • Normalise the fps

@Rajan-p-simform Rajan-p-simform requested a review from Copilot July 7, 2025 13:47
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates project configurations, migrates UI components to use ViewBinding with edge-to-edge support, enhances media picking for Android 13/14, and specifically improves the combine-videos feature by detecting audio streams and normalizing FPS.

  • Add JDK and Gradle updates for build environments.
  • Migrate all activities from Kotlin synthetic imports to ViewBinding and introduce enableEdgeToEdge.
  • Enhance CombineVideosActivity to detect audio streams (hasAudio) and normalize frame rates.

Reviewed Changes

Copilot reviewed 78 out of 80 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
jitpack.yml Added support for OpenJDK 8 alongside 11
gradle/wrapper/gradle-wrapper.properties Upgraded Gradle distribution to 8.5-bin
gradle.properties Suppress compileSdk 35 warnings with new flag
app/src/main/res/values/themes.xml Switched to NoActionBar theme and added toolbar style
app/src/main/res/values/strings.xml Inserted time-picker strings block
app/src/main/res/layout/toolbar_app.xml New toolbar layout without ActionBar
app/src/main/java/.../utils/ExtensionsUtils.kt Added enableEdgeToEdge extension
app/src/main/java/com/simform/videoimageeditor/videoProcessActivity/CombineVideosActivity.kt Improved video combining logic (audio detection, fps normalization)
app/src/main/res/layout/activity_change_audio_valume.xml Included toolbar in audio layout (typo in filename)
Comments suppressed due to low confidence (3)

app/src/main/res/layout/activity_change_audio_valume.xml:1

  • The filename 'activity_change_audio_valume.xml' contains a typo ('valume'). Rename it to 'activity_change_audio_volume.xml' and update references.
<?xml version="1.0" encoding="utf-8"?>

app/src/main/res/values/strings.xml:119

  • [nitpick] The resource name 'title' is too generic and may collide with other modules. Consider renaming to 'time_picker_title' or namespace it for clarity.
    <string name="title">title</string>

app/src/main/res/values/strings.xml:114

  • XML resource files do not support '//' comments; this line will break parsing. Replace with a proper XML comment: .
    // Time Picker

@Rajan-p-simform Rajan-p-simform force-pushed the bugfix/combine-video-query-update branch from 7c2cd2c to 2fe5e6f Compare July 7, 2025 14:14
@Rajan-p-simform Rajan-p-simform force-pushed the bugfix/combine-video-query-update branch from 2fe5e6f to a7699b2 Compare July 15, 2025 11:11
@Rajan-p-simform Rajan-p-simform force-pushed the bugfix/combine-video-query-update branch from a7699b2 to f1b3a5e Compare July 15, 2025 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant