-
Notifications
You must be signed in to change notification settings - Fork 9
Fix legacy remove #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
hjmjohnson
wants to merge
35
commits into
SimpleITK:master
from
InsightSoftwareConsortium:fix-legacy-remove
Closed
Fix legacy remove #40
hjmjohnson
wants to merge
35
commits into
SimpleITK:master
from
InsightSoftwareConsortium:fix-legacy-remove
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add intial check in of maksed assign image filter
Fixes changes made in #2053. ITK_DISALLOW_COPY_AND_ASSIGN will be used if ITK_FUTURE_LEGACY_REMOVE=OFF.
When adding missing macro end-of-line semi-colons, the clang-format corrections make the code more consistent to read.
The test expects an exception to be thrown, when in actuality, it does not. This makes the test verify no exception is thrown.
COMP: Update GitHub Actions from ITKModuleTemplate
Update ITK version and CI updates
The new method resolved the cases where there are no dominant direction in one or more axis. This method chooses the high value in the matrix first, then removes the invalid remaining values to select from.
Fixed choosing orientation for some previous INVALID conditions with greedy algorithm.
The MakeIndex and MakeVector methods are now in the itk namespace.
Update to ITK 5.3rc2
Update GHA from template for ITK 5.3.0
Move GetCoordinateTerm to a private function since it uses private CoordinateMajornessTermsEnum.
Wrap DICOMOrientation
Update to version 1.0
Update build for ITK 5.4.0
chore: Convert from setup.py to pyproject.toml
When preparing for the future with ITK by setting ITK_FUTURE_LEGACY_REMOVE:BOOL=ON ITK_LEGACY_REMOVEBOOL=ON The future preferred macro should be used │ - itkTypeMacro │ + itkOverrideGetNameOfClassMacro
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.