docs: Add all the readmes - #23
Open
ldiego08 wants to merge 4 commits into
Open
Conversation
maccath
previously approved these changes
Oct 14, 2021
maccath
left a comment
maccath
left a comment
Contributor
There was a problem hiding this comment.
One grammar issue, but OK to merge. :)
Co-authored-by: Katy Ereira <katy@skillshare.com>
jeffreybaird
previously approved these changes
Oct 14, 2021
ramsey
previously approved these changes
Oct 14, 2021
ramsey
left a comment
ramsey
left a comment
There was a problem hiding this comment.
Looks great. We need to figure out what email address to add to the code of conduct.
| ## Enforcement | ||
|
|
||
| Instances of abusive, harassing, or otherwise unacceptable behavior may be | ||
| reported by contacting the project team at {{ email }}. All |
There was a problem hiding this comment.
We need to put an email address here for {{ email }}
…n-php into docs/readmes
ramsey
approved these changes
Oct 14, 2021
maccath
approved these changes
Oct 18, 2021
|
Looks great. I just created apollo-federation-php@skillshare.com email group -- @ldiego08 can you switch the email references in this PR to use that address? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes