Conversation
mbouaziz
approved these changes
Mar 3, 2026
Contributor
mbouaziz
left a comment
mbouaziz
left a comment
There was a problem hiding this comment.
Thanks for the first fix
Not sure I get the libbacktrace fix, I'd like to avoid building it all the time
Broken by #1110. Use ${ARRAY[@]+"${ARRAY[@]}"} pattern for IMAGES and EXTRA_BAKE_ARGS to avoid "unbound variable" errors under set -u.
Set "format-on-check": false to prevent skfmt from failing when checking test files that are intentionally ill-formed.
Contributor
Author
|
I split off the libbacktrace commit and will merge the others. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The recent churn broke things for me.
Not sure exactly what made us hit some of these now and not before.