Skip to content

Add option to include formatting in chat rules#2331

Merged
kevinthegreat1 merged 5 commits into
SkyblockerMod:mainfrom
LJNeon:include-formatting
May 6, 2026
Merged

Add option to include formatting in chat rules#2331
kevinthegreat1 merged 5 commits into
SkyblockerMod:mainfrom
LJNeon:include-formatting

Conversation

@LJNeon
Copy link
Copy Markdown
Contributor

@LJNeon LJNeon commented Apr 18, 2026

Adds an option to include chat formatting codes in chat rules. The primary motivation is being able to match those in regex groups for inclusion in the output, for example keeping item name colors.

Testing

Example Chat Rule Use regex on + Include formatting on image
Resulting toasts from above Chat Rule image image image
Filter text box is colored by formatting Use regex off + Include formatting on (can't really color regexes properly) image
Filter text box isn't colored without "include formatting" Use regex off + Include formatting off image

@LifeIsAParadox LifeIsAParadox added the reviews needed This PR needs reviews label Apr 18, 2026
@Alex33856 Alex33856 added the new feature This issue or PR is a new feature label Apr 18, 2026
Comment thread src/main/java/de/hysky/skyblocker/utils/TextTransformer.java
@LJNeon LJNeon force-pushed the include-formatting branch 2 times, most recently from 1982e52 to 0311414 Compare April 22, 2026 01:10
@LJNeon LJNeon force-pushed the include-formatting branch from 0311414 to 6b817ba Compare April 26, 2026 08:07
@LifeIsAParadox LifeIsAParadox added merge me please Pull requests that are ready to merge and removed reviews needed This PR needs reviews labels Apr 26, 2026
@AzureAaron AzureAaron added this to the 6.5.0 milestone Apr 26, 2026
@kevinthegreat1 kevinthegreat1 merged commit 58701d1 into SkyblockerMod:main May 6, 2026
2 checks passed
@LifeIsAParadox LifeIsAParadox removed the merge me please Pull requests that are ready to merge label May 6, 2026
Alex33856 pushed a commit that referenced this pull request May 6, 2026
* Add option to include formatting in chat rules

* Fix issue with filter edit box formatter

* Fix typo in layout rows

* Fix removal of redundant color codes & add test case

* Handle whitespace better

(cherry picked from commit 58701d1)
@LJNeon LJNeon deleted the include-formatting branch May 10, 2026 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new feature This issue or PR is a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants