Skip to content

Add overflow to status bar values if necessary#2335

Merged
kevinthegreat1 merged 3 commits into
SkyblockerMod:mainfrom
LJNeon:overflow-in-bar-value
May 6, 2026
Merged

Add overflow to status bar values if necessary#2335
kevinthegreat1 merged 3 commits into
SkyblockerMod:mainfrom
LJNeon:overflow-in-bar-value

Conversation

@LJNeon
Copy link
Copy Markdown
Contributor

@LJNeon LJNeon commented Apr 19, 2026

Two main changes:

  1. Overflow is added to value unless the status bar option to show overflow separately is enabled.
  2. Instead of ugly Object types for value/max/overflow a toDisplay method (lets bars change how value is converted into the displayed String) is added and those three fields are changed to Integers.

Testing

Overflow is included in bar value when showOverflow is false image
Overflow is excluded from bar value when showOverflow is true image
Text color reverts to normal when there's no overflow image
Custom bar value displays still work as intended image
Bar value is shown as ??? when null image

@LifeIsAParadox LifeIsAParadox added the reviews needed This PR needs reviews label Apr 19, 2026
@LJNeon LJNeon force-pushed the overflow-in-bar-value branch from e0c8838 to 5304a01 Compare April 21, 2026 01:06
@AzureAaron AzureAaron added this to the 6.5.0 milestone Apr 23, 2026
@LJNeon LJNeon force-pushed the overflow-in-bar-value branch from 5304a01 to 785099b Compare April 26, 2026 08:08
@LifeIsAParadox LifeIsAParadox added merge me please Pull requests that are ready to merge and removed reviews needed This PR needs reviews labels Apr 27, 2026
@kevinthegreat1 kevinthegreat1 merged commit cdcbf1e into SkyblockerMod:main May 6, 2026
2 checks passed
@LifeIsAParadox LifeIsAParadox removed the merge me please Pull requests that are ready to merge label May 6, 2026
Alex33856 pushed a commit that referenced this pull request May 6, 2026
* Add overflow to bar values if necessary

* Refactor status bar values

* Change text color to overflow color when applicable

---------

Co-authored-by: Kevinthegreat <92656833+kevinthegreat1@users.noreply.github.com>
(cherry picked from commit cdcbf1e)
@LJNeon LJNeon deleted the overflow-in-bar-value branch May 10, 2026 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants