COMP: Update to newer find_package(Python3) support #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
The Python3 cmake find_package module was first added in version 3.12 This module provides more rigorous support for specifying the exact version and components that are needed. The module has refinements in newer cmake versions to limit the version and specify the ABI required.
vtkAddon/Testing/vtkParallelTransportTest1.cxx:100:21:
warning: unused variable ‘tangentsArray’ [-Wunused-variable]
100 | vtkDoubleArray* tangentsArray = vtkDoubleArray::SafeDownCast(pointData->GetArray("Tangents"));
| ^~~~~~~~~~~~~
vtkAddon/Testing/vtkParallelTransportTest1.cxx:38:10:
warning: unused variable ‘lineDirection’ [-Wunused-variable]
38 | double lineDirection[3] = { 0.0, 0.0, 1.0 };
| ^~~~~~~~~~~~~
jcfr
force-pushed
the
update-python-find-package
branch
from
f1e712c to
5369e78
Compare
lassoan
approved these changes
Aug 20, 2025
Contributor
lassoan
left a comment
lassoan
left a comment
There was a problem hiding this comment.
It looks good to me, too. Let's merge it to fix the VMTK build on linux.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Python3 cmake find_package module was first added in version 3.12
This module provides more rigorous support for specifying
the exact version and components that are needed. The module
has refinements in newer cmake versions to limit the
version and specify the ABI required.