WWSTCERT-10189 Ledvance zigbee meter plug by LQ107 · Pull Request #2729 · SmartThingsCommunity/SmartThingsEdgeDrivers

LQ107 · 2026-01-26T10:10:59Z

Check all that apply

Type of Change

WWST Certification Request
- If this is your first time contributing code:
  - I have reviewed the README.md file
  - I have reviewed the CODE_OF_CONDUCT.md file
  - I have signed the CLA
- I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
Bug fix
New feature
Refactor

Checklist

I have performed a self-review of my code
I have commented my code in hard-to-understand areas
I have verified my changes by testing with a device or have communicated a plan for testing
I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Summary of Completed Tests

greens · 2026-02-04T19:14:19Z

drivers/SmartThings/zigbee-switch/config.yml

+fingerprints:
+  - manufacturer: "LEDVANCE"
+    model: "PLUG COMPACT EU EM T"
+    deviceProfileName: "switch-power-energy"
+    id: "LEDVANCE/PLUG COMPACT EU EM T"
+    deviceLabel: "SMART ZIGBEE COMPACT OUTDOOR PLUG EU"


please remove the changes to this file

drivers/SmartThings/zigbee-switch/fingerprints.yml

drivers/SmartThings/zigbee-switch/src/simple-metering-config/fingerprints.lua

greens · 2026-02-04T19:18:31Z

drivers/SmartThings/zigbee-switch/src/simple-metering-config/can_handle.lua

+local can_handle_simple_metering_config = function(opts, driver, device)
+  -- 检查设备是否支持 Simple Metering 集群 (0x0702)
+  for _, cluster in ipairs(device.server_clusters) do
+    if cluster == 0x0702 then


we have other devices for which this would return true where we would not want your specific device's logic to be used, which is why we usually gate subdrivers via fingerprints

greens · 2026-02-04T19:21:07Z

drivers/SmartThings/zigbee-switch/src/simple-metering-config/init.lua

+local function device_init(driver, device)
+  -- 在设备初始化时设置 multipliers 和 divisors
+  device:configure()
+
+  -- 设置 Multiplier 为 1
+  local write_multiplier_cmd = SimpleMetering.server.commands.WriteAttributes(device)
+  if write_multiplier_cmd then
+    device:send_to_component(
+      write_multiplier_cmd({
+        {id = SimpleMetering.attributes.Multiplier.ID, value = 1, DataType = 0x22} -- 0x22 is 24-bit integer
+      }),
+      "main"
+    )
+  end
+
+  -- 设置 Divisor 为 100
+  local write_divisor_cmd = SimpleMetering.server.commands.WriteAttributes(device)
+  if write_divisor_cmd then
+    device:send_to_component(
+      write_divisor_cmd({
+        {id = SimpleMetering.attributes.Divisor.ID, value = 100, DataType = 0x23} -- 0x23 is 32-bit integer
+      }),
+      "main"
+    )
+  end
+end


It is often the case that the driver init event happens before the radio is up after a hub restart, resulting in zigbee messages failing to be sent. I would recommend moving these to added or configure, since they likely do not need to be re-sent to the device every time they hub restarts.

greens · 2026-02-04T19:24:10Z

drivers/SmartThings/zigbee-switch/src/simple-metering-config/init.lua

+  local divisor = device:get_field(SimpleMetering.attributes.Divisor.ID) or 100
+  local multiplier = device:get_field(SimpleMetering.attributes.Multiplier.ID) or 1


this field is not likely to be set. We do set a similar field from "st.zigbee.constants": constants.SIMPLE_METERING_MULTIPLIER_KEY (and divisor) in our defaults, but we never use the attribute ID as a key,

greens · 2026-02-04T19:26:17Z

drivers/SmartThings/zigbee-switch/src/simple-metering-config/init.lua

+  if write_multiplier_cmd then
+    device:send_to_component(
+      write_multiplier_cmd({
+        {id = SimpleMetering.attributes.Multiplier.ID, value = 1, DataType = 0x22} -- 0x22 is 24-bit integer


we provide "st.zigbee.data_types" which has a Int24 (and Int32 constant)

greens · 2026-02-04T19:26:49Z

drivers/SmartThings/zigbee-switch/src/simple-metering-config/init.lua

+  if write_divisor_cmd then
+    device:send_to_component(
+      write_divisor_cmd({
+        {id = SimpleMetering.attributes.Divisor.ID, value = 100, DataType = 0x23} -- 0x23 is 32-bit integer


in the ZCL this attribute is an Int24

greens

It seems fairly obvious that your AI agent was not up to the task here.

LQ107 · 2026-02-11T05:08:12Z

Hi Steven ， I have updated the driver according to the suggestion you provided. Please help me review it again, thank you very much . Best regards! Long,Jack ***@***.*** 发件人: Steven Green ***@***.***> 发送时间: 2026年2月5日 4:23 收件人: SmartThingsCommunity/SmartThingsEdgeDrivers ***@***.***> 抄送: Long, Jack ***@***.***>; Author ***@***.***> 主题: Re: [SmartThingsCommunity/SmartThingsEdgeDrivers] WWSTCERT-10189 Ledvance zigbee meter plug (PR #2729) You don't often get email from ***@***.******@***.***>. Learn why this is important<https://aka.ms/LearnAboutSenderIdentification> @greens commented on this pull request.

________________________________ In drivers/SmartThings/zigbee-switch/fingerprints.yml<#2729 (comment)>:

- - id: "JNL/Y-K001-001"

- deviceLabel: Yanmi Switch (1 Way) - manufacturer: JNL - model: Y-K001-001 - deviceProfileName: basic-switch - - id: "JNL/Y-K002-001" - deviceLabel: Yanmi Switch (2 Way) 1 - manufacturer: JNL - model: Y-K002-001 - deviceProfileName: basic-switch zigbeeGeneric: please do not remove other partners' fingerprints ― Reply to this email directly, view it on GitHub<#2729 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/B32Y5R5HB5C67Q7L5IPRYLD4KJII5AVCNFSM6AAAAACS4NOPFCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTONJSHA4TGMRYHE>. You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>>

greens · 2026-02-11T23:26:56Z

drivers/SmartThings/zigbee-switch/src/simple-metering-config/init.lua

+local function energy_meter_handler(driver, device, value, zb_rx)
+  local raw_value = value.value
+
+  if type(raw_value) ~= "number" or raw_value < 0 then
+    return
+  end
+
+  local divisor = device:get_field(zigbee_constants.SIMPLE_METERING_DIVISOR_KEY) or 100
+  local multiplier = device:get_field(zigbee_constants.SIMPLE_METERING_MULTIPLIER_KEY) or 1
+
+  if divisor == 0 then
+    return
+  end
+
+  local calculated_value = (raw_value * multiplier) / divisor
+
+  device:emit_event_for_endpoint(
+    zb_rx.address_header.src_endpoint.value,
+    capabilities.energyMeter.energy({ value = calculated_value, unit = "kWh" })
+  )
+end


our default handlers should handle this case, provided your device properly reports its simple metering multiplier and divisor.

I still think this function can be removed.

greens · 2026-02-11T23:27:03Z

drivers/SmartThings/zigbee-switch/src/simple-metering-config/init.lua

@@ -0,0 +1,44 @@
+-- Copyright 2025 SmartThings, Inc.


greens

Based on what you have here, I think all you need to add is the entry in fingerprints.yml. There does not seem to be any device-specific behavior that is different from our default handlers.

LQ107 · 2026-02-26T08:35:19Z

Hi Steven , Thanks for your feedback , when I only add the entry in fingerprints.yml and user Smartthings default handlers , the device can’t show the correct energy meter value in the Smartthings App , the displayed energy meter is 100 times the actual energy meter ,so I need add the sub driver for the device . Is there anything else we need to modify about our sub driver. Best regards! Long,Jack ***@***.*** 发件人: Steven Green ***@***.***> 发送时间: 2026年2月12日 7:28 收件人: SmartThingsCommunity/SmartThingsEdgeDrivers ***@***.***> 抄送: Long, Jack ***@***.***>; Author ***@***.***> 主题: Re: [SmartThingsCommunity/SmartThingsEdgeDrivers] WWSTCERT-10189 Ledvance zigbee meter plug (PR #2729) @greens requested changes on this pull request. Based on what you have here, I think all you need to add is the entry in fingerprints.yml. There does not seem to be any device-specific behavior that is different from our default handlers. ― Reply to this email directly, view it on GitHub<#2729 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/B32Y5R57TKYP2CF52FRLOE34LO3IJAVCNFSM6AAAAACS4NOPFCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTOOBYGAYTQMRZHE>. You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>>

greens · 2026-02-27T21:14:45Z

@LQ107 we should be reading the multiplier and divisor from the device on join. Is that not happening? Is it inaccurate?

greens · 2026-02-27T21:17:07Z

If not, you can simply set the multiplier and divisor fields in your driver's init handler rather than overwriting the default zigbee message handling

either way, we would like to see some unit tests added to verify your code's behavior

LQ107 · 2026-03-03T05:49:25Z

Hi Steven ， Thanks for your feedbacks , according to the idea you provided ,I set the multiplier and divisor fields in your driver's init handler , If there are any other issues with the driver, please contact me. Thank you very much. Best regards! Long,Jack ***@***.*** 发件人: Steven Green ***@***.***> 发送时间: 2026年2月28日 5:17 收件人: SmartThingsCommunity/SmartThingsEdgeDrivers ***@***.***> 抄送: Long, Jack ***@***.***>; Mention ***@***.***> 主题: Re: [SmartThingsCommunity/SmartThingsEdgeDrivers] WWSTCERT-10189 Ledvance zigbee meter plug (PR #2729) [https://avatars.githubusercontent.com/u/123942?s=20&v=4]greens left a comment (SmartThingsCommunity/SmartThingsEdgeDrivers#2729)<#2729 (comment)> If not, you can simply set the multiplier and divisor fields in your driver's init handler rather than overwriting the default zigbee message handling — Reply to this email directly, view it on GitHub<#2729 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/B32Y5RYLCLPDF7A6V2LY75T4OCX6TAVCNFSM6AAAAACS4NOPFCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTSNZVGEZTEOBYG4>. You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>

github-actions · 2026-03-03T19:23:59Z

Invitation URL:
https://bestow-regional.api.smartthings.com/invite/3X215v3EZw2R

github-actions · 2026-03-03T19:27:03Z

Test Results

72 files 488 suites 0s ⏱️
2 658 tests 2 658 ✅ 0 💤 0 ❌
4 506 runs 4 506 ✅ 0 💤 0 ❌

Results for commit 99ce6ea.

github-actions · 2026-03-03T19:27:05Z

File	Coverage
All files	`96%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/laisiao/init.lua	`96%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/preferences.lua	`97%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/lazy_load_subdriver.lua	`57%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/init.lua	`92%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/aqara/init.lua	`94%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/tuya-multi/can_handle.lua	`90%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/inovelli/init.lua	`98%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/inovelli/vzm30-sn/init.lua	`95%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/aqara-light/init.lua	`92%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/configurations/init.lua	`98%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/frient/init.lua	`94%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/aqara/version/init.lua	`94%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/inovelli/vzm32-sn/init.lua	`95%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/frient-IO/unbind_request.lua	`71%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/frient-IO/init.lua	`88%`	❌

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 99ce6ea

greens · 2026-03-03T19:38:03Z

drivers/SmartThings/zigbee-switch/src/simple-metering-config/can_handle.lua

+local can_handle_simple_metering_config = function(opts, driver, device)
+  return device.fingerprinted == true
+end


This is not how you should be checking for a specific device model. This will return true for every device, I expect.

greens · 2026-03-03T19:39:10Z

drivers/SmartThings/zigbee-switch/src/simple-metering-config/init.lua

You should only need the init functions, or just rely on the defaults to read the multiplier/divisor.

Please include some unit tests if you think your changes are necessary.

…dd driver registration processing

LQ107 · 2026-03-04T05:13:52Z

Hi Steven , Thanks for your feedback , according to the modification suggestions you provided, I have modified the sub driver , If there are any other issues with the driver, please contact me. Thank you very much. Best regards! Long,Jack ***@***.*** 发件人: Steven Green ***@***.***> 发送时间: 2026年3月4日 3:40 收件人: SmartThingsCommunity/SmartThingsEdgeDrivers ***@***.***> 抄送: Long, Jack ***@***.***>; Mention ***@***.***> 主题: Re: [SmartThingsCommunity/SmartThingsEdgeDrivers] WWSTCERT-10189 Ledvance zigbee meter plug (PR #2729) @greens commented on this pull request.

…

________________________________ On drivers/SmartThings/zigbee-switch/src/simple-metering-config/init.lua<#2729 (comment)>: You should only need the init functions, or just rely on the defaults to read the multiplier/divisor. Please include some unit tests if you think your changes are necessary. ― Reply to this email directly, view it on GitHub<#2729 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/B32Y5R2Q4H6EJSUCKPCI72T4O4YHHAVCNFSM6AAAAACS4NOPFCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTQOBUGY3DIOBQHE>. You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>

…lict

greens · 2026-03-04T19:49:23Z

check_lua_syntax.ps1

I had removed

greens · 2026-03-04T19:49:42Z

test_can_handle.md

This is not how we handle unit tests. See the /tests directory for examples.

yes ，I had remove this file

greens · 2026-03-05T20:17:49Z

.gitignore

revert these changes

just use git rm to remove files from tracking

greens · 2026-03-05T20:19:09Z

drivers/SmartThings/zigbee-switch/src/simple-metering-config/init.lua

+        [SimpleMetering.attributes.Multiplier.ID] = function(driver, device, value, zb_rx)
+          device:set_field(zigbee_constants.SIMPLE_METERING_MULTIPLIER_KEY, value.value, {persist = true})
+        end,
+        [SimpleMetering.attributes.Divisor.ID] = function(driver, device, value, zb_rx)
+          device:set_field(zigbee_constants.SIMPLE_METERING_DIVISOR_KEY, value.value, {persist = true})


this is already how we handle these attributes by default

this code is redundant

greens · 2026-03-05T20:19:25Z

drivers/SmartThings/zigbee-switch/src/simple-metering-config/init.lua

+  },
+  lifecycle_handlers = {
+    init = function(driver, device)
+      configurations.power_reconfig_wrapper(device_init)(driver, device)


power_reconfig_wrapper has recently been renamed. this code will fail

greens

Change the copyright date to be 2026.

Include some unit tests.

Again, to reiterate for the third time, I do not think any of these changes should be necessary. We read the multiplier and divisor from the device during join and use them for energy calculations.

If that is not your experience when testing, then the only change you need is the init handler to set those fields manually.

…/SmartThingsEdgeDrivers into ledvance_zigbee_meter_plug

LQ107 added 6 commits January 26, 2026 17:55

ledvance zigbee meter plug driver pull

c8278e8

add the handle file

316276d

add driver fingerprints

c01a9d0

modify the ledvance zigbee meter plug device Label

5e5a387

add driver for PLUG EU EM T

98aafe1

delete the PLUG EU EM T driver

6a76283

greens changed the title ~~Ledvance zigbee meter plug~~ WWSTCERT-10189 Ledvance zigbee meter plug Feb 4, 2026

greens reviewed Feb 4, 2026

View reviewed changes

drivers/SmartThings/zigbee-switch/fingerprints.yml Show resolved Hide resolved

greens reviewed Feb 4, 2026

View reviewed changes

drivers/SmartThings/zigbee-switch/src/simple-metering-config/fingerprints.lua Show resolved Hide resolved

greens reviewed Feb 4, 2026

View reviewed changes

greens requested changes Feb 4, 2026

View reviewed changes

Update the PLUG COMPACT EU EM T device driver

14de7ba

greens reviewed Feb 11, 2026

View reviewed changes

greens requested changes Feb 11, 2026

View reviewed changes

set the multiplier and divisor fields in the initial handler

99ce6ea

greens reviewed Mar 3, 2026

View reviewed changes

disable the rely on the defaults to read the multiplier/divisor and A…

22bc75b

…dd driver registration processing

LQ107 requested a review from greens March 4, 2026 06:29

LQ107 added 3 commits March 4, 2026 18:42

fixing the init.lua multiplier/divisor handle ,fixing the commit conf…

b81fa6b

…lict

update sub driver init.lua files

328797c

Merge branch 'main' into ledvance_zigbee_meter_plug

8f598e7

greens reviewed Mar 4, 2026

View reviewed changes

LQ107 added 2 commits March 5, 2026 17:33

Remove unnecessary files

5004c95

Merge branch 'main' into ledvance_zigbee_meter_plug

09b89b7

greens reviewed Mar 5, 2026

View reviewed changes

.gitignore

Copy link

Contributor

greens Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert these changes

just use git rm to remove files from tracking

greens reviewed Mar 5, 2026

View reviewed changes

greens requested changes Mar 5, 2026

View reviewed changes

LQ107 added 4 commits March 6, 2026 09:42

Remove redundant code

3a46f9d

Merge branch 'ledvance_zigbee_meter_plug' of https://github.com/LQ107…

b7eb6b6

…/SmartThingsEdgeDrivers into ledvance_zigbee_meter_plug

Merge branch 'main' into ledvance_zigbee_meter_plug

6b409cb

Merge branch 'main' into ledvance_zigbee_meter_plug

41d31e7

LQ107 requested a review from greens March 10, 2026 06:52

		local divisor = device:get_field(SimpleMetering.attributes.Divisor.ID) or 100
		local multiplier = device:get_field(SimpleMetering.attributes.Multiplier.ID) or 1

Conversation

LQ107 commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Type of Change

Checklist

Description of Change

Summary of Completed Tests

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

greens Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

greens left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

LQ107 commented Feb 11, 2026 via email

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

greens left a comment

Choose a reason for hiding this comment

Uh oh!

LQ107 commented Feb 26, 2026 via email

Uh oh!

greens commented Feb 27, 2026

Uh oh!

greens commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

LQ107 commented Mar 3, 2026 via email

Uh oh!

github-actions bot commented Mar 3, 2026

Uh oh!

github-actions bot commented Mar 3, 2026

Test Results

Uh oh!

github-actions bot commented Mar 3, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

LQ107 commented Mar 4, 2026 via email

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

greens left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

LQ107 commented Jan 26, 2026 •

edited

Loading

greens Feb 4, 2026 •

edited

Loading

greens left a comment •

edited

Loading

greens commented Feb 27, 2026 •

edited

Loading