Refactor make targets #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-mslot
reviewed
Nov 5, 2025
Makefile
Outdated
| $(MAKE) -C pg_lake_benchmark install | ||
|
|
||
| duckdb_pglake: submodules | ||
| # skip duckdb_pglake build if duckdb_pglake library already exists in PG_LIBDIR |
Collaborator
There was a problem hiding this comment.
what if I'm checking out a branch that makes changes to duckdb_pglake?
Collaborator
Author
There was a problem hiding this comment.
what about passing a make variable FORCE_DUCKDB_REBUILD in these cases?
Collaborator
There was a problem hiding this comment.
What about something like make fast for the no rebuild case? :)
(Or make full or something for rebuild)
sfc-gh-abozkurt
force-pushed
the
aykut/refactor-make
branch
2 times, most recently
from
e769770 to
b7847de
Compare
sfc-gh-mslot
approved these changes
Nov 28, 2025
Collaborator
sfc-gh-mslot
left a comment
sfc-gh-mslot
left a comment
There was a problem hiding this comment.
Seems useful. Would appreciate a make fast target without install.
Main thing now is that cloning duckdb submodule can till take an excruciatingly long time. At some point we were able to build without it, assuming DuckDB is installed in /usr.
Signed-off-by: Aykut Bozkurt <[email protected]>
sfc-gh-abozkurt
force-pushed
the
aykut/refactor-make
branch
from
b7847de to
17eb9a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.