A few tweaks to sMAP Direct#17
Open
hobzcalvin wants to merge 2 commits intoSoftwareDefinedBuildings:masterfrom
Open
A few tweaks to sMAP Direct#17hobzcalvin wants to merge 2 commits intoSoftwareDefinedBuildings:masterfrom
hobzcalvin wants to merge 2 commits intoSoftwareDefinedBuildings:masterfrom
Conversation
A simple fix to at least keep the page from breaking when a stream doesn't have any readings. "current value" is "undefined" and "local time" is "Invalid Date" in this case: not pretty, but again, it doesn't break.
Seems more readable to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most importantly, fix the page when a stream has no readings.
(Hi! I'm Grant and I work at Building Robotics with @stevedh.)