Closed
Conversation
Member
|
😍 |
Contributor
|
That's a lot brighter than before. Mainly little things:
Agree would be good have a search icon in the search bar. Although its a filter bar in fact -- it only whittles down the contacts you already have displayed.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does 2 things
Left to be done:
In order to make this change will need to modify solid-ui.login.newAppInstance. could pass in an option in to use the solid-ui button instead to allow for a generic button or a solid-ui button style. I was thinking we could use a 'Secondary' button for contrast.
See this PR in solid-ui https://github.com/solid/solid-ui/pull/478
So far...


b16639cc68.png)