build(gcp): survive a killed poller + --collect recovery#44
Merged
Conversation
Recurring 'build vanished' root cause: when the Mac sleeps, the harness kills the orchestrator, whose teardown trap then DELETED the still-building VM — defeating the autonomous GCS design. Fix: - teardown only deletes the VM on genuine completion (build_done set after the GCS DONE marker is seen). On a mid-build kill it LEAVES the VM up — it finishes on its own, pushes results to GCS, and GCP auto-deletes it at --max-run-duration. - add '--collect <instance>' to recover artifacts + delete a leftover VM whose poller died. - lower max-run-duration cap 5h -> 3h (both profiles finish ~90 min; bounds worst-case cost if the poller dies).
The human-secure binary built fine but the scorecard came back empty — geckodriver couldn't launch it because mach bootstrap installs BUILD deps, not RUNTIME libs. Install libgtk-3/dbus-glib/xt/asound/x11-xcb/pci once before measuring (t64 names with non-t64 fallback for older Ubuntu).
tor-mode build failed: gfxUserFontSet.cpp can't find StaticPrefs_bearbrowser.h. Root cause: the canonical bearbrowser.* StaticPrefList block was only inserted when bearbrowser.webgl.prompt was ALREADY in the YAML (seeded by an earlier patch on 150). On 140 ESR that pref isn't pre-seeded, so the block was skipped -> no bearbrowser.* pref group -> header never generated. Gate insertion on the bidi.* anchor instead; the existing-section strip dedupes the 150 case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Teardown only fires on genuine completion; a mid-build kill leaves the VM to finish + auto-delete, recoverable via --collect. Fixes the recurring build-vanished bug.