Skip to content

build(source-os): make installed sourceos-office path-safe#150

Closed
mdheller wants to merge 2 commits into
mainfrom
officefix1
Closed

build(source-os): make installed sourceos-office path-safe#150
mdheller wants to merge 2 commits into
mainfrom
officefix1

Conversation

@mdheller

@mdheller mdheller commented May 2, 2026

Copy link
Copy Markdown
Contributor

Summary

Fix the installed sourceos-office front door so it resolves sibling helpers first and only falls back to repo-relative helpers when run from the repo tree.

Files:

  • build/office-suite/scripts/sourceos-office
  • build/office-suite/scripts/install_sourceos_office_shell_smoke.sh

Why

Current main stages sourceos-office into ~/.local/bin, but the script still computes ROOT repo-relatively. That works in-repo and breaks when installed. This follow-on closes that installed-path bug and proves it with the shell smoke.

mdheller commented May 3, 2026

Copy link
Copy Markdown
Contributor Author

Agent triage: closing this PR as superseded by current main.

main already includes the installed-path-safe sourceos-office helper and a stronger install_sourceos_office_shell_smoke.sh that covers the installed command, verify path, search path, and new-document path. This branch is also 64 commits behind main, so merging it would be redundant and risky.

@mdheller mdheller closed this May 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant