Add documentation to fix_dtype
#3975
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Also, maybe this should throw a warning so it informs users like in #3969? |
zm711
reviewed
Jun 4, 2025
Comment on lines
403
to
405
| Many preprocessors access scipy functions (e.g. filter) that fail silently with unsigned dtypes. | ||
| This function fixes the dtype to be signed if it is unsigned. | ||
| """ |
Member
There was a problem hiding this comment.
Maybe we are even more verbose? It does 3 things:
- if no dtype is given it will attempt to infer from recording
- It will attempt to convert the dtype to an npt.DTypeLike (I forget the actual typing)
- if the dype is unsigned it will convert to the signed equivalent (--at potential truncation of large values?)
Or am I misunderstanding?
Collaborator
Author
There was a problem hiding this comment.
I made improvements in this direction.
zm711
approved these changes
Jun 4, 2025
Member
zm711
left a comment
zm711
left a comment
There was a problem hiding this comment.
This works for me as long as Alessio is cool with it!
Member
|
Lets close this in favor of this #3982 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the meeting today. Just adding a docstring so we remember why this is here.
Maybe we should change the name to
force_signed_intto make it more clear? we can do this in another PR.