feat(cli): trust custom host CA roots - #3901
Draft
helix-nine wants to merge 7 commits into
Draft
Conversation
helix-nine
force-pushed
the
feat/trust-custom-ca-root
branch
from
September 6, 2026 05:34
21a360b to
c921ee6
Compare
Helix-Harness: pi Helix-Model: openai-codex/gpt-5.6-sol
Helix-Harness: pi Helix-Model: openai-codex/gpt-5.6-sol
Helix-Harness: pi Helix-Model: openai-codex/gpt-5.6-sol
Helix-Harness: pi Helix-Model: openai-codex/gpt-5.6-sol
Helix-Harness: pi Helix-Model: openai-codex/gpt-5.6-sol
Helix-Harness: pi Helix-Model: openai-codex/gpt-5.6-sol
Helix-Harness: pi Helix-Model: openai-codex/gpt-5.6-sol
helix-nine
force-pushed
the
feat/trust-custom-ca-root
branch
from
September 7, 2026 06:45
c921ee6 to
d4acc57
Compare
Contributor
Author
|
High-effort review of
The fix pass also covered relative paths, direct Validation:
A direct |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
start-cli server trust-ca <CERTIFICATE>support for files and stdinstart-cli2.1.0 and update both product changelogs, translations, documentation, and generated manpagesVerification
make start-core-testcargo test -p start-core system::trust_ca::tests --features=testcargo test -p start-core fingerprint_tests --features=testcargo test -p start-core reloadable_http_client_replaces_future_clones --features=testcargo test -p start-core export_manpage_start_cli --features=testcargo test -p start-core start_cli --features=testcargo check -p start-clicargo check -p start-oscargo build -p start-cli --bin start-clicargo build -p start-os --bin startboxcargo fmt --all -- --checkmake start-core-format-checkmake start-cli-format-checkprojects/start-docs/build.shThe first post-rebase manpage-generator run hit corrupted incremental linker artifacts.
cargo clean -p start-coreremoved the stale cache; the same command then passed and regenerated the committed 2.1.0 pages.cargo clippy -p start-core -p start-cli --all-targets --features=testreaches pre-existing#![deny(warnings)]failures inshared-libs/crates/patch-db/json-patch; it reports no finding in the changed code before stopping.Closes #3894