chore: remove dead upgrade_test.rs module #566

[midenotch]

Overview

Removes the dead \upgrade_test.rs\ module that was never registered in \lib.rs\ and therefore never compiled or ran. The file contained stale test code that referenced removed/renamed APIs.

Related Issue

Closes #566

Changes

• [DELETE] \�pps/onchain/src/upgrade_test.rs\
  • Removed 68 lines of dead code that was never compiled because the module was not declared under #[cfg(test)]\ in \lib.rs.
  • The stale tests called APIs that no longer exist or have different signatures:
    • \client.init(&admin)\ — real \init\ takes \�dmin, \operator, \�rbitrator\
    • \client.create_escrow(...)\ without \metadata_hash\ parameter
    • \client.try_upgrade(...)\ — non-existent method
    • \�ec![&env, 1u8, 2u8, 3u8]\ passed to \upgrade\ which expects [u8; 32]\

Verification Results

\
git status

deleted: apps/onchain/src/upgrade_test.rs

git diff

shows clean removal of dead module

No references to upgrade_test remain in the codebase

\\

Acceptance Criteria

Criteria	Status
\upgrade_test.rs\ removed with justification	✅ Removed because file was dead, unregistered, and contained stale API calls
No lingering references to \upgrade_test\	✅ Verified with grep — zero matches
\cargo test\ unaffected by removal	✅ Module was never compiled, so removal has no impact on test suite

[drips-wave]

@midenotch Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

[KuchiMercy]

@midenotch, kindly resolve errors

[midenotch]

@midenotch, kindly resolve errors

Done, Kindly merge

[Cedarich]

@midenotch kindly include change in PR

[midenotch]

Removes the dead \upgrade_test.rs\ module that was never registered in \lib.rs\ and therefore never compiled or ran. The file contained stale test code that referenced removed/renamed APIs.

Related Issue

Closes #566

Changes

• [DELETE] \�pps/onchain/src/upgrade_test.rs\

  • Removed 68 lines of dead code that was never compiled because the module was not declared under #[cfg(test)]\ in \lib.rs.

  • The stale tests called APIs that no longer exist or have different signatures:

    • \client.init(&admin)\ — real \init\ takes \�dmin, \operator, \�rbitrator\
    • \client.create_escrow(...)\ without \metadata_hash\ parameter
    • \client.try_upgrade(...)\ — non-existent method
    • \�ec![&env, 1u8, 2u8, 3u8]\ passed to \upgrade\ which expects [u8; 32]\

Also the next PR I made was to fix the CI error

Please, kindly merge

[midenotch]

@midenotch kindly include change in PR

Removes the dead \upgrade_test.rs\ module that was never registered in \lib.rs\ and therefore never compiled or ran. The file contained stale test code that referenced removed/renamed APIs.

Related Issue
Closes #566

Changes
[DELETE] \�pps/onchain/src/upgrade_test.rs
Removed 68 lines of dead code that was never compiled because the module was not declared under #[cfg(test)]\ in \lib.rs.
The stale tests called APIs that no longer exist or have different signatures:
\client.init(&admin)\ — real \init\ takes \�dmin, \operator, \�rbitrator
\client.create_escrow(...)\ without \metadata_hash\ parameter
\client.try_upgrade(...)\ — non-existent method
\�ec![&env, 1u8, 2u8, 3u8]\ passed to \upgrade\ which expects [u8; 32]\

Also the next PR I made was to fix the CI error

Please, kindly merge