chore: unify mobile env config into single source of truth (closes #557) - #638
Merged
KuchiMercy merged 1 commit intoAug 30, 2026
Merged
Conversation
|
@shychips Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
KuchiMercy
approved these changes
Aug 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unifies mobile environment configuration into a single source of truth. Previously,
services/api.tsandsecurity/env.tsread different environment variables independently, meaning a contributor could set one and silently get the other's default instead.Changes
services/api.tsnow builds its axios instance fromenvConfig.apiUrlinstead of readingEXPO_PUBLIC_API_BASE_URLdirectlyEXPO_PUBLIC_API_BASE_URLfrom the codebase entirelyapps/mobile/.env.exampledocumentingEXPO_PUBLIC_APP_ENV,EXPO_PUBLIC_API_URL, andEXPO_PUBLIC_RPC_URLvalidateEnv()is now called at app startup and surfaces a visible warning in development when config is missingrpcUrldev default from an EVM-style port (http://127.0.0.1:8545) to a proper Soroban RPC endpointAcceptance Criteria
services/api.tsbuilds its axios instance fromenvConfig.apiUrlEXPO_PUBLIC_API_BASE_URLremoved from the codebase.env.exampleadded inapps/mobilevalidateEnv()called at app start with visible dev warningrpcUrldev default corrected to Soroban endpointCloses #557