This repository was archived by the owner on Jun 6, 2022. It is now read-only.
Add BPM horizontal cover with old appid for non-Steam games - #135
Open
SantaHey wants to merge 4 commits into
Open
Add BPM horizontal cover with old appid for non-Steam games#135SantaHey wants to merge 4 commits into
SantaHey wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As said in the Issue 61, BPM covers don't update with actual release.
@aranel616 fixed the issue with the commit 6222596 but fixes it only on the import, not on updating covers.
I saw that @kongomongo fixes it in pull 117 on covers update too.
But his code adds an asset for every type of covers and for every game, even Steam games which result with undefined files.
My commit fixes it only for horizontalGrid and only for Non-Steam games (Steam games use usual ID for BPM pictures)