Fix database query (again), other fixes#4
Open
tacsipacsi wants to merge 4 commits intoSteinsplitter:masterfrom
Open
Fix database query (again), other fixes#4tacsipacsi wants to merge 4 commits intoSteinsplitter:masterfrom
tacsipacsi wants to merge 4 commits intoSteinsplitter:masterfrom
Conversation
The `revision_actor_temp` table was dropped in production in May 2022 (T307906), so presumably this code hasn’t worked since then... Move the query to a function, which is run just before the result is needed. This makes the `unset()` calls unnecessary (the variables that used to be unset are now local ones, so they’re automatically destroyed at the end of the function) and causes at least the header to be shown in case of an exception – the header contains the link to this repo, so interested people have a chance to submit a PR if they figure out what the problem is. Remove `utf8_encode()` calls – everything should be UTF-8 by now, so interpreting user names as ISO-8859-1 (while they are actually UTF-8) and re-encoding them as UTF-8 breaks things rather than fixing them.
If done the other way round, an `E_WARNING` is raised with the message Cannot modify header information - headers already sent and the content type is not set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.