Add view functions for invoice metadata and payment tracking - #646
Open
chukwudiikeh wants to merge 4 commits into
Open
Add view functions for invoice metadata and payment tracking#646chukwudiikeh wants to merge 4 commits into
chukwudiikeh wants to merge 4 commits into
Conversation
- Add pub fn get_invoice_creator(env: Env, invoice_id: u64) -> Address - Returns the creator address for an invoice - Unit test covers basic invoice creator lookup Closes Stellar-split#591
- Add pub fn get_invoice_recipients(env: Env, invoice_id: u64) -> Vec<Address> - Returns the recipients field from InvoiceCore - Unit test verifies the returned list matches the one provided at creation Closes Stellar-split#592
- Add pub fn get_invoice_payment_count(env: Env, invoice_id: u64) -> u32 - Returns invoice.payments.len() as u32 - Unit test confirms count is 0 on a fresh invoice and increases after each pay call Closes Stellar-split#593
- Add pub fn get_invoice_funding_percentage(env: Env, invoice_id: u64) -> u32 - Returns (funded * 10_000 / total) as u32, or 0 if total is 0 - Unit test covers 0%, 50%, and 100% funding cases Closes Stellar-split#594
|
@chukwudiikeh Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds four new view functions to the SplitContract for improved ergonomics and reduced instruction budget for frontends and analytics dashboards:
Changes
contracts/split/src/lib.rscontracts/split/src/test.rsTest Plan
Closes #594
Closes #593
Closes #592
Closes #591