Skip to content

Fix fee bump source account - #728

Merged
Kingsman-99 merged 1 commit into
Stellar-split:mainfrom
kingsrichie79-cmyk:fix/fee-bump-source-final
Aug 29, 2026
Merged

Fix fee bump source account#728
Kingsman-99 merged 1 commit into
Stellar-split:mainfrom
kingsrichie79-cmyk:fix/fee-bump-source-final

Conversation

@kingsrichie79-cmyk

Copy link
Copy Markdown
Contributor

Closes #700

Description:

Description

This PR resolves an issue where src/feeBumpBuilder.ts constructed fee-bump transaction envelopes using the inner transaction's source account instead of the explicitly provided fee-bump payer account. This incorrect assignment was causing transaction submissions to fail with an authorization error.

Root Cause & Fix

When passing a string to @stellar/stellar-sdk's TransactionBuilder.buildFeeBumpTransaction(), the source account was not being properly respected in the resulting envelope, falling back to the inner transaction's source.

To fix this, we now explicitly instantiate a Keypair from the provided feeSource public key using Keypair.fromPublicKey(feeSource). This forces the SDK to use the correct feeSourceAccount, ensuring the fee-bump payer account is set properly while leaving the inner transaction's source untouched.

Acceptance Criteria Met

  • The fee-bump envelope's source account is correctly set from the feeSource parameter passed to buildFeeBump().
  • The inner transaction source account remains unchanged.
  • Added unit tests comparing the built envelope's .feeSource property to the provided feeSource string.
  • All unit tests pass successfully.

@drips-wave

drips-wave Bot commented Aug 28, 2026

Copy link
Copy Markdown

@kingsrichie79-cmyk Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@Kingsman-99
Kingsman-99 merged commit 474ae4f into Stellar-split:main Aug 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feeBumpBuilder.ts: Fix fee-bump envelope not setting the correct source account

2 participants