Fix fee bump source account - #728
Merged
Kingsman-99 merged 1 commit intoAug 29, 2026
Merged
Conversation
|
@kingsrichie79-cmyk Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #700
Description:
Description
This PR resolves an issue where
src/feeBumpBuilder.tsconstructed fee-bump transaction envelopes using the inner transaction's source account instead of the explicitly provided fee-bump payer account. This incorrect assignment was causing transaction submissions to fail with an authorization error.Root Cause & Fix
When passing a string to
@stellar/stellar-sdk'sTransactionBuilder.buildFeeBumpTransaction(), the source account was not being properly respected in the resulting envelope, falling back to the inner transaction's source.To fix this, we now explicitly instantiate a
Keypairfrom the providedfeeSourcepublic key usingKeypair.fromPublicKey(feeSource). This forces the SDK to use the correctfeeSourceAccount, ensuring the fee-bump payer account is set properly while leaving the inner transaction's source untouched.Acceptance Criteria Met
feeSourceparameter passed tobuildFeeBump()..feeSourceproperty to the providedfeeSourcestring.