feat(pathRouter): add findPath with configurable fallback threshold - #729
Merged
Kingsman-99 merged 1 commit intoAug 29, 2026
Merged
Conversation
|
@kingsrichie79-cmyk Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #699
Description:
This PR resolves an issue where
src/pathRouter.tswould return a hard failure (PathNotFoundError) when no payment paths met the required minimum liquidity threshold on the first attempt.To provide callers with a viable (even if more costly) route, this update implements a single-retry fallback mechanism that can dynamically relax the cost threshold.
Key Changes & Implementations:
FindPathParamsinterface encompassingsourceAsset,destinationAsset,threshold, andfallbackSlippagePct.findPath(params)method to thePathRouterclass.threshold * (1 + fallbackSlippagePct/100).PathResultto include an optionalusedFallback: truetelemetry flag to let callers know when the fallback mechanism was utilized to yield the path.Acceptance Criteria Met:
findPath(params)accepts afallbackSlippagePct?: numberoption.threshold * (1 + fallbackSlippagePct/100).usedFallback: trueflag.