Add DarkRP support for vehicle locking and switching seats#274
Open
Vitroze wants to merge 2 commits intoStyledStrike:mainfrom
Open
Add DarkRP support for vehicle locking and switching seats#274Vitroze wants to merge 2 commits intoStyledStrike:mainfrom
Vitroze wants to merge 2 commits intoStyledStrike:mainfrom
Conversation
| return true | ||
| end | ||
|
|
||
| return false |
Owner
There was a problem hiding this comment.
Is this return false supposed to be here? This will make so that, while on DarkRP, not even the owner can lock the vehicle, and it will never run the Glide_CanLockVehicle hook either.
In fact, this code only allows locking the vehicle while switching seats, but you can't switch seats while locking the vehicle so... Everything here is dead code
Contributor
Author
There was a problem hiding this comment.
Since CanEnterLockedVehicle is used once in the Glide code, I initially thought it was used to check if someone wanted to enter the vehicle or not.
However, it's a system to check if it can lock the vehicle.
I just moved the code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
My last pull request regarding compatibility with DarkRP (#263) was accepted. Unfortunately, the key system no longer works after the @StyledStrike has been modified.
The purpose of this pull request is to prevent even the owner in DarkRP from entering a locked vehicle.