Skip to content

Conversation

@FichteFoll
Copy link
Member

This is an alternative approach to #178, using it as an inspiration but going about it slightly differently.

I tried to isolate commits into reasonable chunks.

Things I did:

  • Update repository structure (rename st3 to src).
  • Add pyproject.toml file with dev dependencies & using uv for our toolchain.
  • Require Python 3.8, since 3.3 is finally being deprecated by ST.
  • Remove vendor and combat folders since they are not necessary in 3.8.

Things I did not do:

  • Ensure that tests can still be run with Unittesting.
  • Test anything besides uv build.
  • Reformat or add a formatter configuration.

@deathaxe
Copy link
Member

Require Python 3.8, since 3.3 is finally being deprecated by ST.

IMHO, we should first create a py33 compatible WHEEL release, targeting legacy ST3/4 builds, to totally get rid of legacy dependency releases without breaking unmaintained py33 packages on ST3/4 platform.

A 2nd step then would be to upgrade code base to a py38-only version.

@deathaxe
Copy link
Member

For python 3.8 it may be useful to disable annotation evaluation via from __future__ import annotations to save some CPU cycles.

@FichteFoll
Copy link
Member Author

IMHO, we should first create a py33 compatible WHEEL release, targeting legacy ST3/4 builds, to totally get rid of legacy dependency releases without breaking unmaintained py33 packages on ST3/4 platform.

Just so we are on the same page: This would specifically target ST3 & PC4 environments, right?

@deathaxe
Copy link
Member

Yes, it would.

PC3 doesn't work or upgrades itself to PC4 automatically, hence it is the most likely one in use.

Majority of libraries are shipped via pypi for ST3/py33, already. Only those special purpose dependencies, aren't.

@FichteFoll
Copy link
Member Author

Yeah, makes sense. How exactly does it work when I upload a wheel for, say 0.4.0 with Python 3.3 and for all following releases I would only offer Python 3.8 (and 3.13/14)? Does "the" dependency crawler go through several github releases until it the asset file pattern matches or does it only look at the latest release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants