fix: correct compaction token estimates and completion state - #493
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compaction could report identical before/after token counts despite replacing the history, and a completed manual compaction could leave the chat showing a running response.
This change estimates the replacement provider request after clearing stale Responses replay on a projected context copy, matching the actual checkpoint installation. Ordinary requests retain their native replay. After manual compaction, the chat reloads the persisted terminal state; pending streaming frames cannot overwrite that state, and new live updates invalidate older in-flight loads.
Regression coverage checks compaction and trimming estimates against the resumed request, cached running state after compaction, and both timeline reload/frame ordering cases. Required architecture and module documentation are updated.
Validation completed locally during implementation:
Scope is limited to the compaction fixes, regression tests, and their required technical documentation.