-
Notifications
You must be signed in to change notification settings - Fork 94
Release 7.0.0 #1175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sntiwari1
wants to merge
10
commits into
Sunbird-Lern:release-7.0.0
Choose a base branch
from
SNT01:release-7.0.0
base: release-7.0.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Release 7.0.0 #1175
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
1420f73
Initial plan
Copilot 9fbe036
Add comprehensive Akka to Pekko migration compatibility reports
Copilot 3fdaab5
Add quick reference and documentation index for migration
Copilot 615f44e
Upgrade from Akka 2.5.19 to Apache Pekko 1.0.3
Copilot 4a50f15
Add Pekko upgrade README documentation
Copilot f86901e
Update PEKKO_UPGRADE_README.md to remove file modification details
sntiwari1 6b85df1
Upgrade sunbird-utils from Akka 2.5.19 to Apache Pekko 1.0.3
sntiwari1 c46fee7
fix: Add support for multiple cloud storage types and update dependen…
Deeksha1502 f9c9f47
Update sunbird-platform-core/common-util/pom.xml
Deeksha1502 968cf04
Merge pull request #2 from Deeksha1502/test-release-7.0.0
sntiwari1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,88 @@ | ||
| # Apache Pekko 1.0.3 Upgrade | ||
|
|
||
| ## Overview | ||
|
|
||
| This document describes the upgrade of sunbird-utils repository from Akka 2.5.19 to Apache Pekko 1.0.3. | ||
|
|
||
| ## Why This Upgrade | ||
|
|
||
| 1. License Compliance: Akka changed from Apache 2.0 to Business Source License 1.1, requiring commercial licenses for production use. Apache Pekko maintains Apache 2.0 license. | ||
| 2. Security: Akka 2.5.19 no longer receives security updates. | ||
| 3. Modernization: Access to latest features and performance improvements. | ||
|
|
||
| ## Technology Stack Changes | ||
|
|
||
| - Actor Framework: Akka 2.5.19 to Apache Pekko 1.0.3 | ||
| - Scala: 2.11 to 2.13 | ||
| - Jackson Module Scala: 2.10.1 to 2.14.3 | ||
|
|
||
| ## Key Changes | ||
|
|
||
| ### Dependencies | ||
|
|
||
| All Maven POM files updated with new versions. Scala library exclusions added to prevent version conflicts between Scala 2.11 and 2.13. | ||
|
|
||
| Updated POM files: | ||
| - sunbird-platform-core/actor-core/pom.xml | ||
| - sunbird-platform-core/actor-util/pom.xml | ||
| - sunbird-platform-core/common-util/pom.xml | ||
| - sunbird-es-utils/pom.xml | ||
|
|
||
| ### Source Code | ||
|
|
||
| Akka imports migrated to Pekko across all Java files: | ||
| - akka.actor to org.apache.pekko.actor | ||
| - akka.pattern to org.apache.pekko.pattern | ||
| - akka.routing to org.apache.pekko.routing | ||
| - akka.util to org.apache.pekko.util | ||
| - akka.dispatch to org.apache.pekko.dispatch | ||
|
|
||
| ### Configuration | ||
|
|
||
| Configuration references updated from akka to pekko namespaces: | ||
| - akka.actor.provider to pekko.actor.provider | ||
| - akka.remote.RemoteActorRefProvider to org.apache.pekko.remote.RemoteActorRefProvider | ||
| - akka.remote.netty.tcp to pekko.remote.artery | ||
| - akka:// protocol references to pekko:// | ||
|
|
||
| ### Scala Version Handling | ||
|
|
||
| Added exclusions to prevent Scala 2.11 transitive dependencies: | ||
| - Excluded scala-library and scala-reflect from cloud-store-sdk in common-util | ||
| - Explicitly declared scala-library 2.13.12 dependency across all modules | ||
|
|
||
| ## Build Instructions | ||
|
|
||
| Build all modules: | ||
| ``` | ||
| mvn clean install -DskipTests | ||
| ``` | ||
|
|
||
| Build with tests: | ||
| ``` | ||
| mvn clean install | ||
| ``` | ||
|
|
||
| Check dependency tree for verification: | ||
| ``` | ||
| mvn dependency:tree | ||
| ``` | ||
|
|
||
| ## Migration Impact | ||
|
|
||
| Business Logic: No changes to business logic or functionality | ||
| API Compatibility: Maintained, as Pekko is API-compatible with Akka | ||
| Code Changes: Primarily package name updates from akka to pekko | ||
| License: Now compliant with Apache 2.0 throughout the stack | ||
|
|
||
| ## Verification | ||
|
|
||
| After upgrade, verify: | ||
| 1. Build succeeds without errors | ||
| 2. No Akka dependencies remain: mvn dependency:tree | grep akka | ||
| 3. Pekko dependencies present: mvn dependency:tree | grep pekko | ||
| 4. All tests pass | ||
|
|
||
| ## Known Issues | ||
|
|
||
| Scala 2.11/2.13 Conflict: If you encounter NoClassDefFoundError for scala.collection classes, verify dependency tree to ensure no Scala 2.11 artifacts are present. Run mvn dependency:tree and add exclusions for any scala-library or scala-reflect with version 2.11. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
sunbird-es-utils/src/main/java/org/sunbird/common/ElasticSearchRestHighImpl.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
sunbird-es-utils/src/main/java/org/sunbird/common/ElasticSearchTcpImpl.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 4 additions & 4 deletions
8
sunbird-platform-core/actor-core/src/main/java/org/sunbird/actor/core/BaseActor.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...tform-core/actor-core/src/main/java/org/sunbird/actor/router/BackgroundRequestRouter.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
...rd-platform-core/actor-core/src/main/java/org/sunbird/actor/service/SunbirdMWService.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...atform-core/actor-util/src/main/java/org/sunbird/actorutil/InterServiceCommunication.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...tor-util/src/main/java/org/sunbird/actorutil/courseenrollment/CourseEnrollmentClient.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...src/main/java/org/sunbird/actorutil/courseenrollment/impl/CourseEnrollmentClientImpl.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...latform-core/actor-util/src/main/java/org/sunbird/actorutil/email/EmailServiceClient.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...ore/actor-util/src/main/java/org/sunbird/actorutil/email/impl/EmailServiceClientImpl.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 3 additions & 3 deletions
6
...re/actor-util/src/main/java/org/sunbird/actorutil/impl/InterServiceCommunicationImpl.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The HOCON configuration format requires newlines or proper delimiters between properties, not commas. Using commas as delimiters will cause parsing errors. Change
StringUtils.join(details, \",\")toStringUtils.join(details, \"\\n\")to properly format the configuration string.