Allow to define a template in action definition - #377
Merged
GSadee merged 1 commit intoMay 23, 2025
Conversation
loic425
force-pushed
the
feature/allow-to-define-template-in-action
branch
6 times, most recently
from
May 20, 2025 07:48
8f89772 to
9134f27
Compare
loic425
force-pushed
the
feature/allow-to-define-template-in-action
branch
from
May 20, 2025 07:51
9134f27 to
902ef9c
Compare
diimpp
approved these changes
May 20, 2025
GSadee
approved these changes
May 23, 2025
Member
|
Thank you @loic425! 🎉 |
NoResponseMate
added a commit
to Sylius/SyliusResourceBundle
that referenced
this pull request
May 26, 2025
| Q | A | --------------- | ----- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Related tickets | | License | MIT Related to Sylius/SyliusGridBundle#377
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace #376
In the package, there are two ways of defining the template.
1/ On Field => within options property
2/ On Filter => directly within template property
Indeed the grid could be used in non-Twig/non-HTML context.
Definining the template in the options could be more detached to "HTML", but I think it's simpler for the DX to define this within a simple setTemplate. For now we use grids within HTML in 100% of the case, and even I already have some PoC to define console operations with grids, this is not bad to keep that getter/setter unused there.