Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there 👋
I am migrating an old Sylius app from v1 to v2, upgrading also symfony to SF7.4.
During upgrade, I noticed that my old migrations raised an exception as the ContainerAwareInterface does not longer exist.
I tried to migrate migrations to services, enabling this in my doctrine_migration config
It works well BUT it didn't see anymore any migration from sylius core and plugin.
The Factory added in the PR will automatically retrieve migration as service if registered with tag
doctrine_migrations.migration, and if not retrieve any, fallback to the current factory.It's allow to having some migration as service, and kept the whole migration discovery process from core/plugin working.
enable_service_migrationsin your config. If you leave it enabled, Doctrine Migrations will ignore the factory override and use its default service provider instead, so no core/plugin migration will be visible.