Repository navigation
ci: bind dispatched image builds to the verified source commit - #246
Merged
Merged
Conversation
![sylphx-desk-services[bot]](https://avatars.githubusercontent.com/u/206448049?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Checkout and build evidence now use the supplied verified source commit together, while callers omitting the input retain the event commit. The source contract test covers both bindings, and the checks passed at this head. No blocking regression found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
The reusable image lane accepts an optional
source-sha. Checkout andSOURCE_SHAbuild evidence bind that exact commit; existing callers default to the triggering commit.Why
Downstream image publication must follow the successful post-merge Verify marker without accidentally building a newer main tip that has not been verified. A dispatch on main keeps the existing publisher identity while supplying the verified source separately.
Verification
Remote build at
320949aeffc6ecd8d574cb7a138405df5aaf77ae:python3 -m unittest discover -s tests -p test_image_lane_tools.pypassed all 32 tests.Remote actionlint 1.7.12 exited 1 for the two existing
job.workflow_shacontext errors at lines 198 and 265 (unchanged from main, previously lines 191 and 258). No new lint finding was reported. The validation binary was removed afterward.