Repository navigation
fix(ci): move shared diagnostics and iOS handovers to run-store - #247
Open
sylphx-desk-studio[bot] wants to merge 4 commits into
Open
sylphx-desk-studio[bot] wants to merge 4 commits into
sylphx-desk-studio[bot] wants to merge 4 commits into
Conversation
Contributor
Author
There was a problem hiding this comment.
- B1 [class: missing-consumer-integration]: Complete the required successful authenticated consumer invocation before acceptance (PROJECT.md:33-36). tests/test_run_store_junit.py:47-66 replaces both GitHub metadata and run-store transport with mocks, and .github/workflows/project-control.yml:39-102 invokes only unrelated consumers. The passing suite does not demonstrate that the new reusable workflow checkout, caller OIDC permissions, producer-step discovery and cross-run retrieval work together. Supply a successful invocation at this head that retrieves sharded JUnit through run-store and preserves exact job/test identity, or add this consumer integration to CI and publish a new head. The submitted verification notes explicitly leave this check outstanding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
run-store put <name>contract; resolve the target repository ID and preserve exact matrix-job/test attribution through a metadata map.Verification
No builds, tests, linters, formatters, workflow reruns or billing calls were run, per assignment. No artifacts were deleted.
Review should run the run-store/JUnit, red-main and iOS-release Python regression suites and shared workflow lint after admission.
Rollout
Consumers must repin the shared workflow SHA and grant
id-token: write. JUnit producers must use an explicit matchingrun-store put <name>top-level step name, including expanded shard names. External iOS prebuilt-IPA producers must publish the named run-store entry before callers adopt this head. Existing release/audit evidence remains untouched.Merge ownership
Desk reviewer owns exact-head review and merge-queue arming via
gh pr merge --auto --squash --match-head-commit d5c21651b7447684dfdaa734e69bea9e07bd8eaconce required CI/review gates are satisfied. No bypass merge.