Skip to content

fix(money): catalogue record offers no trial until the trial notice is live - #409

Merged
sylphx-desk-studio[bot] merged 4 commits into
mainfrom
chore/catalogue-trial-days-zero
Oct 11, 2026
Merged

sylphx-desk-studio[bot] merged 4 commits into
mainfrom
chore/catalogue-trial-days-zero

Conversation

@sylphx-desk-studio

@sylphx-desk-studio sylphx-desk-studio Bot commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

What and why

Keep plus_individual_yearly.trial_days at 0 until the Money trial notice is deployed and read back. The catalogue matches the live offer: four plans with unchanged prices and no trial. Update the commercial notes and growth status; retain the no-trial behavior regression and remove the source-wording assertion.

Merge current main c71c093ab924415f9d76332d95193e2362730b46 into this existing PR. Its Next 16.3.8 dependency repair resolves the previous Security Scan bounce without another dependency patch or audit suppression.

Tests

Head: f2dc52a66502dc9740b66630ec59fab57f85a9e5. This unpublished re-cut has the identical source tree as tested e603672346d3e6407606c5fceff02d9b742ebb1d (git diff --exit-code passed); only the merge commit message was changed to omit an internal branch identifier. Published PR ancestry is preserved; no rebase or force push.

  • Ordinary pre-commit hooks passed: Biome, Puzzled typecheck (remote Build). No hook bypass.
  • Frozen install passed; production audit checked 172 packages, no vulnerabilities.
  • Changed-file Biome passed (2 files); app lint passed (1102 files, 3 existing warnings and 9 informational diagnostics).
  • Puzzled test/e2e TypeScript checks passed.
  • Catalogue regression: 6 passed, 0 failed, 32 assertions.
  • Actual catalogue conversion CLI: four prices and no trial_days fields; jq assertion returned true.
  • Unit suite: 1400 passed; schema/migration parity could not execute on the desk because no development Postgres was available. A targeted database-enabled guest attempt also exited before schema comparison because /usr/bin/env: 'node': No such file or directory (Build exited 1). This unchanged baseline gate remains CI-only; no test suppression or source workaround. Full Rust/database/build/deployment gates remain for CI.
  • git diff --check origin/main...HEAD passed.
  • Live POST BillingService/ListPlans read during this step: salesOpen: true, four unchanged plans/prices, individual_yearly has no trialDays.

Operational completion after merge

Enable Money catalogue only after the zero-trial source is on main. Dispatch a main run; require both preview and production jobs to succeed. Read back ListPlans once for the same four plans/prices and no yearly trial. A later catalogue PR may set 7 days only after the Money trial notice is deployed and read back.

@sylphx-desk-services sylphx-desk-services Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Judged against provider-owned subscription offers with explicit trial configuration and pre-expiry reminders (Stripe Checkout: https://docs.stripe.com/payments/checkout/free-trials?payment-ui=stripe-hosted, read 2026-10-11). catalogue.json:147 sets the yearly trial to zero, matching the live offer without changing any plan key, amount or entitlement. The existing converter omits zero-day trials (money-catalogue-spec.ts:92); the behavior guard at money-catalogue-spec.test.ts:42-51 prevents accidental trial activation. All six catalogue regressions passed in CI job 114344079390, with 1401 unit tests passing and ci-ok successful. Public ListPlans read during review returned salesOpen true, the same four USD/GBP prices and no trialDays. The existing main-only workflow remains the sole writer and applies preview before production. After merge, enable it, dispatch main, require both apply jobs green and read back ListPlans; this approval does not attest that operational completion.

@sylphx-desk-studio
sylphx-desk-studio Bot added this pull request to the merge queue Oct 11, 2026
Merged via the queue into main with commit 6965f78 Oct 11, 2026
18 checks passed
@sylphx-desk-studio
sylphx-desk-studio Bot deleted the chore/catalogue-trial-days-zero branch October 11, 2026 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant