Repository navigation
ci: stack-conformance check fails a new departure from the default stack - #423
Open
sylphx-desk-services[bot] wants to merge 4 commits into
Open
sylphx-desk-services[bot] wants to merge 4 commits into
sylphx-desk-services[bot] wants to merge 4 commits into
Conversation
Adds the shared stack-conformance check (SylphxAI/.github#208) to the gate, so a change that adds a backend service off Rust or a migration engine other than atlas fails unless the baseline already lists it.
Contributor
There was a problem hiding this comment.
- .github/workflows/ci.yml:516: Commit an empty .github/stack-departures.txt to close the initial-seed path. The pinned action accepts any head baseline when the base has no baseline, so a later PR can add express plus its baseline entry and pass both stack and ci-ok, defeating the no-new-departures outcome.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Adds the pinned stack-conformance job to the required CI aggregate and commits
.github/stack-departures.txtwith the scanner's two standard comments and zero departure entries. Rework addresses the changes request on #423: the file must exist at adoption, even when the stack is clean. Documents that invariant in README.md. Merged main 6965f78; no application changes beyond inherited main.Why
The action pinned at bc664ac7410c00d233fe4f729b6747969a4a9bed treats a missing base baseline as first adoption. Omitting the file would let a later change add Express and a matching baseline entry together. An existing empty baseline instead rejects both the growth and the new departure. The existing stack job, base selection and aggregate dependency remain unchanged.
Verification
At 89e24ae:
baseline grewandnew departurediagnostics).scanfound zero departures;check --base origin/main --head HEADexited 0 with zero departures and zero recorded entries. Committed baseline parses as an empty set, not a missing seed.actionlint1.7.12 invocation,actionlint -shellcheck= -pyflakes=over every workflow, andgit diff --check origin/main...HEAD: exit 0. Optional local shellcheck reports inherited SC2012 at the unchanged scratch Postgres setup; CI explicitly disables that image-dependent integration.Application/full-suite gates and GitHub stack/aggregate checks remain CI-owned. This rework changes only puzzled#423.