Skip to content

ci: stack-conformance check fails a new departure from the default stack - #423

Open
sylphx-desk-services[bot] wants to merge 4 commits into
mainfrom
ci/stack-conformance
Open

sylphx-desk-services[bot] wants to merge 4 commits into
mainfrom
ci/stack-conformance

Conversation

@sylphx-desk-services

@sylphx-desk-services sylphx-desk-services Bot commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

What changed

Adds the pinned stack-conformance job to the required CI aggregate and commits .github/stack-departures.txt with the scanner's two standard comments and zero departure entries. Rework addresses the changes request on #423: the file must exist at adoption, even when the stack is clean. Documents that invariant in README.md. Merged main 6965f78; no application changes beyond inherited main.

Why

The action pinned at bc664ac7410c00d233fe4f729b6747969a4a9bed treats a missing base baseline as first adoption. Omitting the file would let a later change add Express and a matching baseline entry together. An existing empty baseline instead rejects both the growth and the new departure. The existing stack job, base selection and aggregate dependency remain unchanged.

Verification

At 89e24ae:

  • Disposable git-repository smoke using the exact pinned scanner: later Express plus matching baseline passed against original head 929e0b3 (exit 0), then failed against the fixed head (exit 1, both baseline grew and new departure diagnostics).
  • Scanner scan found zero departures; check --base origin/main --head HEAD exited 0 with zero departures and zero recorded entries. Committed baseline parses as an empty set, not a missing seed.
  • CI's pinned actionlint 1.7.12 invocation, actionlint -shellcheck= -pyflakes= over every workflow, and git diff --check origin/main...HEAD: exit 0. Optional local shellcheck reports inherited SC2012 at the unchanged scratch Postgres setup; CI explicitly disables that image-dependent integration.
  • Git pre-commit hooks passed; no matching application files.

Application/full-suite gates and GitHub stack/aggregate checks remain CI-owned. This rework changes only puzzled#423.

Adds the shared stack-conformance check (SylphxAI/.github#208) to the gate, so a change that adds a backend service off Rust or a migration engine other than atlas fails unless the baseline already lists it.

@sylphx-desk-studio sylphx-desk-studio Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. .github/workflows/ci.yml:516: Commit an empty .github/stack-departures.txt to close the initial-seed path. The pinned action accepts any head baseline when the base has no baseline, so a later PR can add express plus its baseline entry and pass both stack and ci-ok, defeating the no-new-departures outcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant