Repository navigation
fix(ci): defer mutable dependency audits to the launch gate - #429
Open
sylphx-desk-studio[bot] wants to merge 5 commits into
Open
sylphx-desk-studio[bot] wants to merge 5 commits into
sylphx-desk-studio[bot] wants to merge 5 commits into
Conversation
Contributor
Author
There was a problem hiding this comment.
The consumer removes the mutable registry audit while retaining verified-secret detection and the required job name; browser budgets remain enabled after merge and on schedules. The exact consumer head passed ci-ok. This adopts the action from companion pull request SylphxAI/.github#234, which is still unmerged and has failing checks; land its corrected, independently reviewed action first and repin this consumer if its SHA changes. No consumer code blockers found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove the mutable-registry dependency audit and its unused Bun setup from the PR
Security Scanjob. Retain the required job name and verified-secret detection unchanged. Pin sharedworkflow-lintto77f1fd9da44cc1b382ca4cf24d8573cbda4564b2, which guards against direct package-manager audits returning to the pre-merge gate. Record the deferred launch audit checklist in the CI reference.Why
The sharp advisory in
GHSA-wq5f-xc86-pv6wfailed an unchanged PR dependency: advisory publication is not a source regression. Unrelated PR authors must not repair the same trunk dependency repeatedly. During development, security audits are deferred to launch. At launch the existing dependency bot owns advisory repairs, and a separate daily default-branch audit owns detection, without feeding source-culprit automatic rollback orci-ok.This adopts the companion shared workflow-lint change. The queue entry is created after that exact shared action head is pushed, so the pinned object exists before CI resolves it.
How tested
git diff origin/main HEAD --checkpassed; native pre-commit hooks ran and skipped unrelated TypeScript checks.No dependency-version, gameplay, authentication, database, schema or runtime change. Rollback is reverting the workflow and documentation change.