feat: add select component #328
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
|
commit: |
LzhengH
reviewed
Nov 28, 2025
src/popup/popup.tsx
Outdated
|
|
||
| install(): void { | ||
| window.addEventListener('resize', this.updatePopper); | ||
| if (this.triggerRef.current) { |
Collaborator
There was a problem hiding this comment.
这段测试过生效么？按理说放到installed钩子里才能生效
Collaborator
Author
There was a problem hiding this comment.
昨晚推了一个feat: popup添加width监听能力 & 修复authWidth下web components的 宽度问题修改，尝试并验证了这些问题，但不知道为什么它们是同一个cr 但没有显示在 diff 里....
| } | ||
| } | ||
|
|
||
| updateCommonInputProps() { |
Collaborator
There was a problem hiding this comment.
这个写法不太符合直觉，用计算属性更好一点
get commonInputProps() {
const { loading, suffixIcon } = this.props;
return {
...pick(this.props, COMMON_PROPERTIES),
suffixIcon: loading ? : suffixIcon,
};
}
| export default class LoadingDemo extends Component { | ||
| options = []; | ||
|
|
||
| loading = false; |
Collaborator
There was a problem hiding this comment.
调用this.update()触发响应式不是推荐用法，可以参考下比较新的组件的示例，比如chat-sender里的例子。响应式属性应该用signal()包裹，类似react里的useState，就可以在更新时触发响应式渲染
|
|
||
| import type { SelectContext, TdOptionProps } from '../type'; | ||
|
|
||
| const currentValue = signal(''); |
Collaborator
There was a problem hiding this comment.
currentValue和currentOption放到SelectBase的成员变量里吧，标准一点
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 改动项
t-select和t-option组件和相关测试用例t-fake-arrow这个收起/展开图标的样式问题，及下游组件collapse对它的调用方法loading组件作为输入框后缀图标不能居中的问题popup组件在 visible 时异常闪烁的问题DEVELOP_GUIDE.md中的新增组件部分文档select,popup的 setExportparts 功能input,panel支持容器宽高监听能力，以实现select组件的弹窗宽度和定位跟随功能🤔 这个 PR 的性质是？
🔗 相关 Issue
#11
☑️ 请求合并前的自查清单