-
Notifications
You must be signed in to change notification settings - Fork 322
[Feature] Add Architecture Decision Record implementation to be used in ArchRule reason #1496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
3dcf31a to
f770ab3
Compare
|
Thanks for your contribution! While I think it's nice to be able to define MADRs programmatically, this feature seems to be quite independent of ArchUnit. (The only dependency of your classes on ArchUnit is the |
|
ArchUnit rules reflect key architectural decisions, but the rationale behind those decisions is typically buried in code or comments. This feature would allow automatic generation of Markdown Architecture Decision Records (ADRs) directly from ArchUnit rules, capturing why a rule exists—not just what it enforces. Benefits:
This would bring ArchUnit closer to being not only a verification tool, but also a lightweight architectural documentation aid. What is your mind about this explanation? |
|
I fully agree that ArchRules should document the reasoning for the constraints they encode. 👍
I see that you could use an ArchRule = /* rule definition */.because(adr.toString());(which you can already do with any |
|
Yes, you're right, it would be more complicated than I think to generate ADR from ArchUnit rule 😢 |
c5bf983 to
91ab89d
Compare
Signed-off-by: Romain Rochegude <[email protected]>
Signed-off-by: Romain Rochegude <[email protected]>
Signed-off-by: Romain Rochegude <[email protected]>
Signed-off-by: Romain Rochegude <[email protected]>
Signed-off-by: Romain Rochegude <[email protected]>
…rchRule reason Signed-off-by: Romain Rochegude <[email protected]>
Signed-off-by: Romain Rochegude <[email protected]>
Signed-off-by: Romain Rochegude <[email protected]>
Signed-off-by: Romain Rochegude <[email protected]>
Signed-off-by: Romain Rochegude <[email protected]>
Signed-off-by: Romain Rochegude <[email protected]>
Signed-off-by: Romain Rochegude <[email protected]>
Signed-off-by: Romain Rochegude <[email protected]>
Signed-off-by: Romain Rochegude <[email protected]>
Signed-off-by: Romain Rochegude <[email protected]>
Signed-off-by: Romain Rochegude <[email protected]>
Signed-off-by: Romain Rochegude <[email protected]>
ee25470 to
ac65868
Compare
|
But you are right, the typical use case I target is the following:
|
Hello,
This Pull Request includes:
Resolves #1495
Thank you for reviewing.
Regards.