Skip to content

fix(concurrency): resolve Swift concurrency warnings#1764

Open
andiahmads wants to merge 1 commit into
TableProApp:mainfrom
andiahmads:fix/swift-concurrency-warnings
Open

fix(concurrency): resolve Swift concurrency warnings#1764
andiahmads wants to merge 1 commit into
TableProApp:mainfrom
andiahmads:fix/swift-concurrency-warnings

Conversation

@andiahmads

Copy link
Copy Markdown

Summary

Swift concurrency checks no longer flag these app paths for detached-task capture, main-actor default arguments, or non-Sendable filesystem enumeration. SQL review preparation now resolves actor-isolated plugin metadata before leaving the main actor, while detached work only formats already-derived values.

The SQL folder watcher keeps synchronous filesystem enumeration out of async scanning, the import picker publishes an immutable importer-state snapshot back to the main actor, and WelcomeViewModel preserves its production initializer behavior without a main actor-isolated default parameter.

Testing

  • env -u CPATH -u CPLUS_INCLUDE_PATH -u C_INCLUDE_PATH -u LIBRARY_PATH -u CPPFLAGS -u CFLAGS -u CXXFLAGS -u LDFLAGS xcodebuild -project TablePro.xcodeproj -scheme TablePro -configuration Debug -destination platform=macOS,arch=arm64 -skipPackagePluginValidation CODE_SIGNING_ALLOWED=NO build
  • env -u CPATH -u CPLUS_INCLUDE_PATH -u C_INCLUDE_PATH -u LIBRARY_PATH -u CPPFLAGS -u CFLAGS -u CXXFLAGS -u LDFLAGS xcodebuild -project TablePro.xcodeproj -scheme TablePro -configuration Debug -destination platform=macOS,arch=arm64 -skipPackagePluginValidation CODE_SIGNING_ALLOWED=NO test -only-testing:TableProTests/SQLReviewSheetTests -only-testing:TableProTests/WelcomeViewModelTests
  • git diff --check

Not run: swiftlint and swiftformat, because neither tool is installed in this environment.

Post-Deploy Monitoring & Validation

No additional operational monitoring required. This is a compile-time Swift concurrency cleanup with no expected runtime behavior change; the macOS Debug build and targeted tests are the validation signal.


Compound Engineering
GPT_5

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant