fix(concurrency): resolve Swift concurrency warnings#1764
Open
andiahmads wants to merge 1 commit into
Open
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Swift concurrency checks no longer flag these app paths for detached-task capture, main-actor default arguments, or non-Sendable filesystem enumeration. SQL review preparation now resolves actor-isolated plugin metadata before leaving the main actor, while detached work only formats already-derived values.
The SQL folder watcher keeps synchronous filesystem enumeration out of async scanning, the import picker publishes an immutable importer-state snapshot back to the main actor, and
WelcomeViewModelpreserves its production initializer behavior without a main actor-isolated default parameter.Testing
env -u CPATH -u CPLUS_INCLUDE_PATH -u C_INCLUDE_PATH -u LIBRARY_PATH -u CPPFLAGS -u CFLAGS -u CXXFLAGS -u LDFLAGS xcodebuild -project TablePro.xcodeproj -scheme TablePro -configuration Debug -destination platform=macOS,arch=arm64 -skipPackagePluginValidation CODE_SIGNING_ALLOWED=NO buildenv -u CPATH -u CPLUS_INCLUDE_PATH -u C_INCLUDE_PATH -u LIBRARY_PATH -u CPPFLAGS -u CFLAGS -u CXXFLAGS -u LDFLAGS xcodebuild -project TablePro.xcodeproj -scheme TablePro -configuration Debug -destination platform=macOS,arch=arm64 -skipPackagePluginValidation CODE_SIGNING_ALLOWED=NO test -only-testing:TableProTests/SQLReviewSheetTests -only-testing:TableProTests/WelcomeViewModelTestsgit diff --checkNot run:
swiftlintandswiftformat, because neither tool is installed in this environment.Post-Deploy Monitoring & Validation
No additional operational monitoring required. This is a compile-time Swift concurrency cleanup with no expected runtime behavior change; the macOS Debug build and targeted tests are the validation signal.