ci: stop running the source editor package tests that cannot build on the runner - #2051
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainis red. TheCodeEditSourceEditortest step I added in #2049 cannot build on the runner, so it fails every PR and every push to main.The failure is a build error, not a test failure:
preceded by
warning: 'textstory': skipping cache due to an error: The file "maintenance.lock" doesn't exist. The resource-bundle accessor for a dependency checkout is not generated underswift teston this runner. It builds locally under Xcode 27 with a warm.build, which is why I did not catch it, and it builds fine inside the Xcode project, so the app target is unaffected.Removing the step restores the gate. The comment left in its place records why, so it does not get re-added blind: the package also has pre-existing failures on main (
HighlighterTests,TagEditingTests, and one test that aborts the runner), so it needs fixing at the package level before it can gate anything.CodeEditTextViewstill runs and still passes, so the editor package that carries the double-click and selection regression tests remains covered.Cost of the gap:
TextViewControllerTestsis no longer gated on CI. It passes locally viaswift test --package-path LocalPackages/CodeEditSourceEditor --filter TextViewControllerTests.