Skip to content

ci: stop running the source editor package tests that cannot build on the runner - #2051

Merged
datlechin merged 1 commit into
mainfrom
fix/ci-drop-source-editor-step
Aug 9, 2026
Merged

ci: stop running the source editor package tests that cannot build on the runner#2051
datlechin merged 1 commit into
mainfrom
fix/ci-drop-source-editor-step

Conversation

@datlechin

Copy link
Copy Markdown
Member

main is red. The CodeEditSourceEditor test step I added in #2049 cannot build on the runner, so it fails every PR and every push to main.

The failure is a build error, not a test failure:

CodeEditSymbols/Sources/CodeEditSymbols/CodeEditSymbols.swift:14:42: error: type 'Bundle' has no member 'module'
error: fatalError

preceded by warning: 'textstory': skipping cache due to an error: The file "maintenance.lock" doesn't exist. The resource-bundle accessor for a dependency checkout is not generated under swift test on this runner. It builds locally under Xcode 27 with a warm .build, which is why I did not catch it, and it builds fine inside the Xcode project, so the app target is unaffected.

Removing the step restores the gate. The comment left in its place records why, so it does not get re-added blind: the package also has pre-existing failures on main (HighlighterTests, TagEditingTests, and one test that aborts the runner), so it needs fixing at the package level before it can gate anything.

CodeEditTextView still runs and still passes, so the editor package that carries the double-click and selection regression tests remains covered.

Cost of the gap: TextViewControllerTests is no longer gated on CI. It passes locally via swift test --package-path LocalPackages/CodeEditSourceEditor --filter TextViewControllerTests.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@datlechin
datlechin merged commit 0c36b4d into main Aug 9, 2026
4 checks passed
@datlechin
datlechin deleted the fix/ci-drop-source-editor-step branch August 9, 2026 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant